Re: Potential use of uninitialized context in pgcrypto

2020-10-16 Thread Tom Lane
Daniel Gustafsson writes: > Even though we know that the digest algorithm exists when we reach the second > call, we must check the returnvalue from each call to px_find_digest to handle > allocation errors. Agreed, it's a bug. Will push in a bit. regards, tom lane

Potential use of uninitialized context in pgcrypto

2020-10-16 Thread Daniel Gustafsson
In px_crypt_md5() we have this section, with the second assignment to err being unchecked: /* */ err = px_find_digest("md5", ); if (err) return NULL; err = px_find_digest("md5", ); Even though we know that the digest algorithm exists when we reach the second call, we must