Re: Question about BarrierAttach spinlock

2019-05-23 Thread Mark Dilger
On Thu, May 23, 2019 at 3:44 PM Thomas Munro wrote: > > On Fri, May 24, 2019 at 4:10 AM Mark Dilger wrote: > > In src/backend/storage/ipc/barrier.c, BarrierAttach > > goes to the bother of storing the phase before > > releasing the spinlock, and then returns the phase. > > > > In nodeHash.c, Exec

Re: Question about BarrierAttach spinlock

2019-05-23 Thread Thomas Munro
On Fri, May 24, 2019 at 4:10 AM Mark Dilger wrote: > In src/backend/storage/ipc/barrier.c, BarrierAttach > goes to the bother of storing the phase before > releasing the spinlock, and then returns the phase. > > In nodeHash.c, ExecHashTableCreate ignores the > phase returned by BarrierAttach, and

Question about BarrierAttach spinlock

2019-05-23 Thread Mark Dilger
Hackers, In src/backend/storage/ipc/barrier.c, BarrierAttach goes to the bother of storing the phase before releasing the spinlock, and then returns the phase. In nodeHash.c, ExecHashTableCreate ignores the phase returned by BarrierAttach, and then immediately calls BarrierPhase to get the phase