Re: [PATCH][BUG FIX] Unsafe access pointers.

2019-11-15 Thread Daniel Gustafsson
> On 15 Nov 2019, at 12:25, Ranier Vilela wrote: > It's probably not happening, but it can happen, I think. I don't think it can, given how elog() works. > - if (!HeapTupleIsValid(classtup)) > + if (!HeapTupleIsValid(classtup)) { > elog(ERROR, "cache lookup failed for oper

RE: [PATCH][BUG FIX] Unsafe access pointers.

2019-11-15 Thread Ranier Vilela
Hi, Thank you for the explanation. Best regards. Ranier Vilela De: Daniel Gustafsson Enviado: sexta-feira, 15 de novembro de 2019 11:58 Para: Ranier Vilela Cc: pgsql-hackers@lists.postgresql.org Assunto: Re: [PATCH][BUG FIX] Unsafe access pointers. >

Re: [PATCH][BUG FIX] Unsafe access pointers.

2019-11-18 Thread Alvaro Herrera
On 2019-Nov-15, Ranier Vilela wrote: > Hi, > Last time, I promise. > > It's probably not happening, but it can happen, I think. This patch assumes that anything can happen after elog(ERROR). That's wrong -- under ERROR or higher, elog() (as well as ereport) never returns to the caller. If this