Fujita-san,
> From: Etsuro Fujita [mailto:etsuro.fuj...@gmail.com]
>
> Mochizuki-san,
>
> On Wed, Jun 12, 2019 at 6:08 PM wrote:
> > > On Mon, Jun 10, 2019 at 9:04 PM Etsuro Fujita
> > >
> > > wrote:
> > > > I'll look into the patch more closely tomorrow.
> > >
> > > I did that, but couldn't f
Mochizuki-san,
On Wed, Jun 12, 2019 at 6:08 PM wrote:
> > On Mon, Jun 10, 2019 at 9:04 PM Etsuro Fujita
> > wrote:
> > > I'll look into the patch more closely tomorrow.
> >
> > I did that, but couldn't find any issue about the patch. Here is an updated
> > version of the patch. Changes are:
>
Fujita-san,
> On Mon, Jun 10, 2019 at 9:04 PM Etsuro Fujita
> wrote:
> > I'll look into the patch more closely tomorrow.
>
> I did that, but couldn't find any issue about the patch. Here is an updated
> version of the patch. Changes are:
>
> * Reworded the comments a bit in postgresPlanFoereig
Amit-san,
On Wed, Jun 12, 2019 at 3:33 PM Amit Langote wrote:
> On Wed, Jun 12, 2019 at 3:14 PM Etsuro Fujita wrote:
> > * Reworded the comments a bit in postgresPlanFoereignModify the
> > original patch modified
>
> + * statement, and for UPDATE if BEFORE ROW UPDATE triggers since those
> +
Fujita-san,
On Wed, Jun 12, 2019 at 3:14 PM Etsuro Fujita wrote:
> I did that, but couldn't find any issue about the patch. Here is an
> updated version of the patch.
Thanks for the updating the patch.
> Changes are:
>
> * Reworded the comments a bit in postgresPlanFoereignModify the
> origin
On Mon, Jun 10, 2019 at 9:04 PM Etsuro Fujita wrote:
> I'll look into the patch more closely tomorrow.
I did that, but couldn't find any issue about the patch. Here is an
updated version of the patch. Changes are:
* Reworded the comments a bit in postgresPlanFoereignModify the
original patch m
Fujita-san,
On Tue, Jun 11, 2019 at 6:09 PM Etsuro Fujita wrote:
> On Tue, Jun 11, 2019 at 1:31 PM Amit Langote wrote:
> > > On Tue, Jun 11, 2019 at 10:51 AM Etsuro Fujita
> > > wrote:
> > > > Sorry, my explanation was not good; I should have said that in UPDATE,
> > > > we fetch columns not m
Amit-san,
On Tue, Jun 11, 2019 at 1:31 PM Amit Langote wrote:
> > On Tue, Jun 11, 2019 at 10:51 AM Etsuro Fujita
> > wrote:
> > > Sorry, my explanation was not good; I should have said that in UPDATE,
> > > we fetch columns not mentioned in the SQL query as well (even if the
> > > target table
> On Tue, Jun 11, 2019 at 10:51 AM Etsuro Fujita
> wrote:
> > On Tue, Jun 11, 2019 at 10:30 AM Amit Langote
> > wrote:
> > > On Mon, Jun 10, 2019 at 9:04 PM Etsuro Fujita
> > > wrote:
> > > > > On Tue, May 28, 2019 at 12:54 PM Amit Langote
> > > > > wrote:
> > > > > > On 2019/05/27 22:02, To
I forgot to send this by "Reply ALL".
On Tue, Jun 11, 2019 at 10:51 AM Etsuro Fujita wrote:
>
> Amit-san,
>
> On Tue, Jun 11, 2019 at 10:30 AM Amit Langote wrote:
> > On Mon, Jun 10, 2019 at 9:04 PM Etsuro Fujita
> > wrote:
> > > > On Tue, May 28, 2019 at 12:54 PM Amit Langote
> > > > wrote:
Fujita-san,
Thanks for the comments.
On Mon, Jun 10, 2019 at 9:04 PM Etsuro Fujita wrote:
> > On Tue, May 28, 2019 at 12:54 PM Amit Langote
> > wrote:
> > > On 2019/05/27 22:02, Tom Lane wrote:
> > > > Perhaps, if the table has relevant BEFORE triggers, we should just
> > > > abandon
> > > > o
On Tue, May 28, 2019 at 3:40 PM Etsuro Fujita wrote:
> On Tue, May 28, 2019 at 12:54 PM Amit Langote
> wrote:
> > On 2019/05/27 22:02, Tom Lane wrote:
> > > Amit Langote writes:
> > >> On 2019/05/27 10:52, Shohei Mochizuki wrote:
> > >>> I noticed returning a modified record in a row-level BEFOR
Hi,
On Tue, May 28, 2019 at 12:54 PM Amit Langote
wrote:
> On 2019/05/27 22:02, Tom Lane wrote:
> > Amit Langote writes:
> >> On 2019/05/27 10:52, Shohei Mochizuki wrote:
> >>> I noticed returning a modified record in a row-level BEFORE UPDATE trigger
> >>> on postgres_fdw foreign tables do not
Mochizuki-san,
On 2019/05/28 13:10, Shohei Mochizuki wrote:
> On 2019/05/28 12:54, Amit Langote wrote:
>> On 2019/05/27 22:02, Tom Lane wrote:
>>> Perhaps, if the table has relevant BEFORE triggers, we should just abandon
>>> our attempts to optimize away fetching/storing all columns? It seems li
On 2019/05/28 12:54, Amit Langote wrote:
On 2019/05/27 22:02, Tom Lane wrote:
Amit Langote writes:
On 2019/05/27 10:52, Shohei Mochizuki wrote:
I noticed returning a modified record in a row-level BEFORE UPDATE trigger
on postgres_fdw foreign tables do not work. Attached patch fixes this issu
On 2019/05/27 22:02, Tom Lane wrote:
> Amit Langote writes:
>> On 2019/05/27 10:52, Shohei Mochizuki wrote:
>>> I noticed returning a modified record in a row-level BEFORE UPDATE trigger
>>> on postgres_fdw foreign tables do not work. Attached patch fixes this issue.
>>> This is because current fd
Amit Langote writes:
> On 2019/05/27 10:52, Shohei Mochizuki wrote:
>> I noticed returning a modified record in a row-level BEFORE UPDATE trigger
>> on postgres_fdw foreign tables do not work. Attached patch fixes this issue.
>> This is because current fdw code adds only columns to RemoteSQL that
Mochizuki-san,
On 2019/05/27 10:52, Shohei Mochizuki wrote:
> Hi,
>
> I noticed returning a modified record in a row-level BEFORE UPDATE trigger
> on postgres_fdw foreign tables do not work. Attached patch fixes this issue.
>
> Without attached patch:
>
> postgres=# UPDATE rem1 set f1 = 10;
> po
18 matches
Mail list logo