Re: Fix replica identity checks for MERGE command on published table.

2025-08-27 Thread Dean Rasheed
On Thu, 21 Aug 2025 at 04:41, Zhijie Hou (Fujitsu) wrote: > > On Friday, July 11, 2025 3:09 PM Dean Rasheed > wrote: > > > > In HEAD, it would be OK to change the signature of > > CheckValidResultRel() and pass it an onConflictAction argument to fix > > the ON CONFLICT DO UPDATE issue. However,

Re: Fix replica identity checks for MERGE command on published table.

2025-08-21 Thread Chao Li
Hi Zhijie, > On Aug 21, 2025, at 11:41, Zhijie Hou (Fujitsu) > wrote: > > > Thanks for working on the patch. I tested it locally, and it worked for me properly. Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/

RE: Fix replica identity checks for MERGE command on published table.

2025-08-20 Thread Zhijie Hou (Fujitsu)
On Friday, July 11, 2025 3:09 PM Dean Rasheed wrote: > > On Tue, 8 Jul 2025 at 09:51, Dean Rasheed > wrote: > > > > Answering my own question, INSERT ... ON CONFLICT DO UPDATE does > have > > the same problem as MERGE. To reproduce the error, all you need to do > > is create the unique index it

Re: Fix replica identity checks for MERGE command on published table.

2025-07-11 Thread Dean Rasheed
On Tue, 8 Jul 2025 at 09:51, Dean Rasheed wrote: > > Answering my own question, INSERT ... ON CONFLICT DO UPDATE does have > the same problem as MERGE. To reproduce the error, all you need to do > is create the unique index it needs *after* creating the publication The other question is whether w

Re: Fix replica identity checks for MERGE command on published table.

2025-07-08 Thread Dean Rasheed
On Mon, 7 Jul 2025 at 18:17, Dean Rasheed wrote: > > This makes me wonder though, does INSERT ... ON CONFLICT DO UPDATE > have the same problem as MERGE? > Answering my own question, INSERT ... ON CONFLICT DO UPDATE does have the same problem as MERGE. To reproduce the error, all you need to do i

Re: Fix replica identity checks for MERGE command on published table.

2025-07-07 Thread Dean Rasheed
On Mon, 14 Apr 2025 at 05:40, Ashutosh Bapat wrote: > > I was wondering whether we should mention MERGE somewhere in the error > message like "cannot merge into table ...". But the error message is > reported depending upon the actual operation being performed and > whether it's being published by

Re: Fix replica identity checks for MERGE command on published table.

2025-04-13 Thread Ashutosh Bapat
On Fri, Apr 11, 2025 at 10:54 AM Zhijie Hou (Fujitsu) wrote: > > Hi, > > While testing publication DDLs, I noticed an unexpected behavior where the > MERGE command can be executed on tables lacking replica identity keys, > regardless of whether they are part of a publication that publishes updates