Re: RFC: pg_stat_logmsg

2024-07-17 Thread Michael Paquier
On Wed, Jul 17, 2024 at 07:43:13AM -0400, Joe Conway wrote: > On 7/16/24 18:14, Tomas Vondra wrote: >> As for the feature, I've never done a fleet-wide analysis, so if this is >> one of the main use cases, I'm not really sure I can judge if this is a >> good tool for that. It seems like it might be

Re: RFC: pg_stat_logmsg

2024-07-17 Thread Michael Paquier
On Wed, Jul 17, 2024 at 07:48:15AM -0400, Joe Conway wrote: > I think including version in the key makes most sense. Also do we even have > a mechanism to grab the commit sha in running code? Not directly, still that's doable. The closest thing I would consider here is to get the output of someth

Re: RFC: pg_stat_logmsg

2024-07-17 Thread Joe Conway
On 7/16/24 19:08, Michael Paquier wrote: On Wed, Jul 17, 2024 at 12:14:36AM +0200, Tomas Vondra wrote: I noticed this patch hasn't moved since September 2023, so I wonder what's the main blocker / what is needed to move this? + /* Location of permanent stats file (valid when database is shut d

Re: RFC: pg_stat_logmsg

2024-07-17 Thread Joe Conway
On 7/16/24 18:14, Tomas Vondra wrote: I noticed this patch hasn't moved since September 2023, so I wonder what's the main blocker / what is needed to move this? Mainly me finding time I'm afraid. As for the feature, I've never done a fleet-wide analysis, so if this is one of the main use case

Re: RFC: pg_stat_logmsg

2024-07-16 Thread Michael Paquier
On Wed, Jul 17, 2024 at 12:14:36AM +0200, Tomas Vondra wrote: > I noticed this patch hasn't moved since September 2023, so I wonder > what's the main blocker / what is needed to move this? + /* Location of permanent stats file (valid when database is shut down) */ + #define PGLM_DUMP_FILEP

Re: RFC: pg_stat_logmsg

2024-07-16 Thread Tomas Vondra
Hi, I noticed this patch hasn't moved since September 2023, so I wonder what's the main blocker / what is needed to move this? As for the feature, I've never done a fleet-wide analysis, so if this is one of the main use cases, I'm not really sure I can judge if this is a good tool for that. It se

Re: RFC: pg_stat_logmsg

2023-09-13 Thread Joe Conway
On 7/9/23 14:13, Joe Conway wrote: On 7/7/23 01:38, Gurjeet Singh wrote: In this case, the error message stored in pg_stat_logmsg is just '%s'. The filename and line number columns might help identify the actual error but it requires users to read the source code and cannot know the actual error

Re: RFC: pg_stat_logmsg

2023-07-09 Thread Joe Conway
On 7/7/23 01:38, Gurjeet Singh wrote: On Thu, Jul 6, 2023 at 12:37 AM Masahiko Sawada wrote: On Sat, Jul 1, 2023 at 8:57 AM Joe Conway wrote: > > The basic idea is to mirror how pg_stat_statements works, except the > logged messages keyed by filename, lineno, and elevel are saved with a > aggr

Re: RFC: pg_stat_logmsg

2023-07-06 Thread Gurjeet Singh
On Thu, Jul 6, 2023 at 12:37 AM Masahiko Sawada wrote: > On Sat, Jul 1, 2023 at 8:57 AM Joe Conway wrote: > > > > The basic idea is to mirror how pg_stat_statements works, except the > > logged messages keyed by filename, lineno, and elevel are saved with a > > aggregate count. The format string

Re: RFC: pg_stat_logmsg

2023-07-06 Thread Masahiko Sawada
Hi, On Sat, Jul 1, 2023 at 8:57 AM Joe Conway wrote: > > Greetings, > > Attached please find a tarball (rather than a patch) for a proposed new > contrib extension, pg_stat_logmsg. > > The basic idea is to mirror how pg_stat_statements works, except the > logged messages keyed by filename, lineno

Re: RFC: pg_stat_logmsg

2023-07-01 Thread Joe Conway
On 6/30/23 23:20, Pavel Stehule wrote: so 1. 7. 2023 v 1:57 odesílatel Joe Conway > napsal: Part of the thinking is that people with fleets of postgres instances can use this to scan for various errors that they care about. Additionally it would be useful to

Re: RFC: pg_stat_logmsg

2023-06-30 Thread Pavel Stehule
Hi so 1. 7. 2023 v 1:57 odesílatel Joe Conway napsal: > Greetings, > > Attached please find a tarball (rather than a patch) for a proposed new > contrib extension, pg_stat_logmsg. > > The basic idea is to mirror how pg_stat_statements works, except the > logged messages keyed by filename, lineno

RFC: pg_stat_logmsg

2023-06-30 Thread Joe Conway
Greetings, Attached please find a tarball (rather than a patch) for a proposed new contrib extension, pg_stat_logmsg. The basic idea is to mirror how pg_stat_statements works, except the logged messages keyed by filename, lineno, and elevel are saved with a aggregate count. The format string