Re: [PATCH] Add error_on_null() to produce an error if the input is null

2025-08-31 Thread Vik Fearing
On 31/08/2025 16:10, Joel Jacobson wrote: Does it have a commitfest entry where I can make that official? Yes:https://commitfest.postgresql.org/patch/6017/ Thank you.  Updated. -- Vik Fearing

Re: [PATCH] Add error_on_null() to produce an error if the input is null

2025-08-31 Thread Joel Jacobson
On Sun, Aug 31, 2025, at 15:54, Vik Fearing wrote: > On 31/08/2025 10:04, Joel Jacobson wrote: >> Thanks for great feedback. New patch attached. > > > This new patch resolves all of my concerns and I think it is ready for > committer. Thanks for reviewing. > Does it have a commitfest entry wher

Re: [PATCH] Add error_on_null() to produce an error if the input is null

2025-08-31 Thread Vik Fearing
On 31/08/2025 10:04, Joel Jacobson wrote: Thanks for great feedback. New patch attached. This new patch resolves all of my concerns and I think it is ready for committer.  Does it have a commitfest entry where I can make that official? -- Vik Fearing

Re: [PATCH] Add error_on_null() to produce an error if the input is null

2025-08-31 Thread Joel Jacobson
On Sat, Aug 30, 2025, at 18:38, Tom Lane wrote: > Vik Fearing writes: >> On 30/08/2025 13:49, Joel Jacobson wrote: >>> This polymorphic function produces an error if the input value is null, >>> otherwise it returns the input value unchanged. > >> This only checks for the null value. I don't thin

Re: [PATCH] Add error_on_null() to produce an error if the input is null

2025-08-30 Thread Tom Lane
Vik Fearing writes: > On 30/08/2025 13:49, Joel Jacobson wrote: >> This polymorphic function produces an error if the input value is null, >> otherwise it returns the input value unchanged. > This only checks for the null value. I don't think we need to change > the function's name, but we do n

Re: [PATCH] Add error_on_null() to produce an error if the input is null

2025-08-30 Thread Vik Fearing
On 30/08/2025 13:49, Joel Jacobson wrote: Dear fellow hackers, This polymorphic function produces an error if the input value is null, otherwise it returns the input value unchanged. This only checks for the null value.  I don't think we need to change the function's name, but we do need t