Re: [PATCH] Finally split StdRdOptions into HeapOptions and ToastOptions

2021-07-22 Thread Nikolay Shaplov
В письме от среда, 14 июля 2021 г. 15:09:12 MSK пользователь vignesh C написал: > The patch does not apply on Head anymore, could you rebase and post a > patch. I'm changing the status to "Waiting for Author". Thank you for notification. I've tried to rebase it and found out that some options h

Re: [PATCH] Finally split StdRdOptions into HeapOptions and ToastOptions

2021-07-14 Thread vignesh C
On Sun, Sep 13, 2020 at 9:34 PM Nikolay Shaplov wrote: > > В письме от понедельник, 20 июля 2020 г. 18:36:44 MSK пользователь Georgios > Kokolatos написал: > > Hi! Sorry for really long delay, I was at my summer vacations, and then has > urgent things to finish first. :-( Now I hope we can continu

Re: [PATCH] Finally split StdRdOptions into HeapOptions and ToastOptions

2021-06-20 Thread Nikolay Shaplov
В письме от пятница, 4 июня 2021 г. 3:19:09 MSK пользователь Jeff Davis написал: > > Moving reloptions to AM code is the goal I am slowly moving to. I've > > started > > some time ago with big patch > > https://commitfest.postgresql.org/14/992/ and > > have been told to split it into smaller part

Re: [PATCH] Finally split StdRdOptions into HeapOptions and ToastOptions

2021-06-03 Thread Jeff Davis
On Sun, 2020-09-13 at 19:04 +0300, Nikolay Shaplov wrote: > Moving reloptions to AM code is the goal I am slowly moving to. I've > started > some time ago with big patch > https://commitfest.postgresql.org/14/992/ and > have been told to split it into smaller parts. So I did, and this > patch is

Re: [PATCH] Finally split StdRdOptions into HeapOptions and ToastOptions

2021-03-05 Thread David Steele
Hi Georgios, On 9/13/20 12:04 PM, Nikolay Shaplov wrote: В письме от понедельник, 20 июля 2020 г. 18:36:44 MSK пользователь Georgios Kokolatos написал: thank you for the patch. It applies cleanly, compiles and passes check, check-world. Thank you for reviewing efforts. Please find new v

Re: [PATCH] Finally split StdRdOptions into HeapOptions and ToastOptions

2020-09-13 Thread Nikolay Shaplov
В письме от понедельник, 20 июля 2020 г. 18:36:44 MSK пользователь Georgios Kokolatos написал: Hi! Sorry for really long delay, I was at my summer vacations, and then has urgent things to finish first. :-( Now I hope we can continue... > thank you for the patch. It applies cleanly, compiles a

Re: [PATCH] Finally split StdRdOptions into HeapOptions and ToastOptions

2020-07-20 Thread Georgios Kokolatos
The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: not tested Spec compliant: not tested Documentation:not tested Hi, thank you for the patch. It applies cleanly, compiles and passes check,

Re: [PATCH] Finally split StdRdOptions into HeapOptions and ToastOptions

2020-07-03 Thread Nikolay Shaplov
В письме от четверг, 2 июля 2020 г. 17:15:13 MSK пользователь Daniel Gustafsson написал: > > A new version of the patch. > > Autovacuum options were extended in b07642db > > > > So I added that options to the current patch. > > The heapam.c hunk in this version fails to apply to HEAD, can you p

Re: [PATCH] Finally split StdRdOptions into HeapOptions and ToastOptions

2020-07-02 Thread Daniel Gustafsson
> On 28 Mar 2020, at 19:57, Nikolay Shaplov wrote: > > A new version of the patch. > Autovacuum options were extended in b07642db > > So I added that options to the current patch. The heapam.c hunk in this version fails to apply to HEAD, can you please submit a rebased version? Marking the CF

Re: [PATCH] Finally split StdRdOptions into HeapOptions and ToastOptions

2020-03-28 Thread Nikolay Shaplov
A new version of the patch. Autovacuum options were extended in b07642db So I added that options to the current patch.diff --git a/src/backend/access/common/reloptions.c b/src/backend/access/common/reloptions.c index e136116..55bd1ec 100644 --- a/src/backend/access/common/reloptions.c +++ b/src/ba

Re: [PATCH] Finally split StdRdOptions into HeapOptions and ToastOptions

2020-03-07 Thread Nikolay Shaplov
В письме от суббота, 7 марта 2020 г. 10:03:40 MSK пользователь Michael Paquier написал: > On Wed, Mar 04, 2020 at 10:58:31PM +0300, Nikolay Shaplov wrote: > > But the truth is that my goal is to move all code that defines all option > > names, min/max values etc, move it inside am code. To move da

Re: [PATCH] Finally split StdRdOptions into HeapOptions and ToastOptions

2020-03-06 Thread Michael Paquier
On Wed, Mar 04, 2020 at 10:58:31PM +0300, Nikolay Shaplov wrote: > But the truth is that my goal is to move all code that defines all option > names, min/max values etc, move it inside am code. To move data from > boolRelOpts, intRelOpts, realRelOpts, enumRelOpts, enumRelOpts from > reloptions.c

Re: [PATCH] Finally split StdRdOptions into HeapOptions and ToastOptions

2020-03-04 Thread Nikolay Shaplov
В письме от понедельник, 9 декабря 2019 г. 12:11:17 MSK пользователь Michael Paquier написал: > On Fri, Dec 06, 2019 at 06:18:48PM +0300, Nikolay Shaplov wrote: > > In the thread > > https://www.postgresql.org/message-id/2620882.s52SJui4ql@x200m > > I've suggested to split one big StdRdOption that

Re: [PATCH] Finally split StdRdOptions into HeapOptions and ToastOptions

2019-12-08 Thread Michael Paquier
On Fri, Dec 06, 2019 at 06:18:48PM +0300, Nikolay Shaplov wrote: > In the thread > https://www.postgresql.org/message-id/2620882.s52SJui4ql@x200m > I've suggested to split one big StdRdOption that is used for options storage > into into Options structures individual for each relkind and each rela