Re: [PATCH] Perform check for oversized WAL record before calculating record CRC

2025-09-07 Thread Sergey Fukanchik
It seems to me reasonable to move size check above CRC computation. However, it seems suspicious to me to run a test that allocates 1Gb in `make check`. Maybe, there are places that are not exercised too often. Perhaps recovery tests or something like that. Hi Andrey, I share your concern ab

Re: [PATCH] Perform check for oversized WAL record before calculating record CRC

2025-09-06 Thread Andrey Borodin
> On 6 Sep 2025, at 16:00, Sergey Fukanchik wrote: > > <0001-Perform-check-for-oversized-WAL-record-before-calcul.patch> Hi Sergey! It seems to me reasonable to move size check above CRC computation. However, it seems suspicious to me to run a test that allocates 1Gb in `make check`. Maybe,