Re: [PATCH] contrib/xml2: xslt_process() should report XSLT-related error details

2025-07-09 Thread Robin Haberkorn
And yet again after the changes introduced in 93001888d85c21a5b9ab1fe8dabfecb673fc007c by Tom Lane I had to rebase my patches (see attachments). An open question on the 2nd patch remains how to properly expose xml_parse(). That is, if somebody is interested in merging it at all. You might want to

Re: [PATCH] contrib/xml2: xslt_process() should report XSLT-related error details

2025-07-07 Thread Robin Haberkorn
After the changes introduced by Michael Paquier (commited as 732061150b004385810e522f8629f5bf91d977b7) I had to rebase my patches. Among other things pg_xml_error_occurred() was already called except after xsltSaveResultToString(). From what I understand, it's not really necessary to mangle the enc

Re: [PATCH] contrib/xml2: xslt_process() should report XSLT-related error details

2025-05-07 Thread Robin Haberkorn
Hello again, I did prepare another patch, which introduces an xmltype-based alternative for xslt_process(). I would really like to put that up for discussion. IMHO with this patch, xslt_process() should be ready to be adopted into core. Unfortunately, it cleanly applies only on top of the error h

Re: [PATCH] contrib/xml2: xslt_process() should report XSLT-related error details

2025-04-28 Thread Robin Haberkorn
On Tue Apr 22, 2025 at 17:47:20 GMT +03, Robin Haberkorn wrote: > Perhaps you can tell me what else is preventing adoption into core. I believe > that xslt_process() should also accept the `xml` type as an alternative to > strings. Strings should be kept for backwards compatibility, though. Also, >

Re: [PATCH] contrib/xml2: xslt_process() should report XSLT-related error details

2025-04-24 Thread Robin Haberkorn
On Thu Apr 24, 2025 at 01:59:10 GMT +03, Tom Lane wrote: > Hm. I wonder if we couldn't get rid of the > HAVE_XMLSTRUCTUREDERRORCONTEXT conditionalization. If the > libxml2 versions that lacked that were "old" in 2011, surely > they are extinct in the wild by now. I'm thinking that we > really do

Re: [PATCH] contrib/xml2: xslt_process() should report XSLT-related error details

2025-04-23 Thread Tom Lane
"Robin Haberkorn" writes: > btw. you wrote that comment in cacd42d62cb2ddf32135b151f627780a5509780f > back in 2011. > The commit message also contains some background information. Hm. I wonder if we couldn't get rid of the HAVE_XMLSTRUCTUREDERRORCONTEXT conditionalization. If the libxml2 versio

Re: [PATCH] contrib/xml2: xslt_process() should report XSLT-related error details

2025-04-23 Thread Robin Haberkorn
On Wed Apr 23, 2025 at 00:42:06 GMT +03, Robin Haberkorn wrote: > /* > * Legacy error handling mode. err_occurred is never set, we just add the > * message to err_buf. This mode exists because the xml2 contrib module > * uses our error-handling infrastructure, but we don't want to change its >

Re: [PATCH] contrib/xml2: xslt_process() should report XSLT-related error details

2025-04-22 Thread Robin Haberkorn
Hello Tom! On Tue Apr 22, 2025 at 18:29:02 GMT +03, Tom Lane wrote: > Hi Robin, thank you for the patch! This has arrived too late to > be considered for PG v18, but please add the thread to the open > commitfest I will do that. But what about the other changes I proposed (xml data type and hsto

Re: [PATCH] contrib/xml2: xslt_process() should report XSLT-related error details

2025-04-22 Thread Tom Lane
"Robin Haberkorn" writes: > I forgot the patch of course... Hi Robin, thank you for the patch! This has arrived too late to be considered for PG v18, but please add the thread to the open commitfest https://commitfest.postgresql.org/53/ so that we don't forget about it for v19, and so that it

Re: [PATCH] contrib/xml2: xslt_process() should report XSLT-related error details

2025-04-22 Thread Robin Haberkorn
I forgot the patch of course... -- Robin Haberkorn Senior Software Engineer B1 Systems GmbH Osterfeldstraße 7 / 85088 Vohburg / https://www.b1-systems.de GF: Ralph Dehner / Unternehmenssitz: Vohburg / AG: Ingolstadt, HRB 3537 From cc5be302aa4305403b8131f6c22c39e4dfb75bd1 Mon Sep 17 00:00:00 2001