Re: 002_types.pl fails on some timezones on windows

2021-10-02 Thread Tom Lane
Thomas Munro writes: > On Sun, Oct 3, 2021 at 11:26 AM Tom Lane wrote: >> I'd still defend our exception for Central America: CLDR maps that >> to Guatemala which seems pretty random, even if they haven't observed >> DST there for a few years. For the rest of it, though, "we follow CLDR" >> has

Re: 002_types.pl fails on some timezones on windows

2021-10-02 Thread Tom Lane
Andres Freund writes: > On October 2, 2021 3:26:35 PM PDT, Tom Lane wrote: >> However, the example >> we started the thread with is that Andres thought "Greenwich Standard >> Time" would get him UTC, or at least something a lot less oddball than >> what he got. > FWIW, that was just the default

Re: 002_types.pl fails on some timezones on windows

2021-10-02 Thread Thomas Munro
On Sun, Oct 3, 2021 at 11:26 AM Tom Lane wrote: > > Eyeballing these, three look strange to me in a list of otherwise > > city-based names: Pacific/Guam (instead of Port Moresby, capital of > > PNG which apparently shares zone rules with the territory of Guam) and > > Pacific/Samoa (country name i

Re: 002_types.pl fails on some timezones on windows

2021-10-02 Thread Andres Freund
Hi, On October 2, 2021 3:26:35 PM PDT, Tom Lane wrote: >However, the example >we started the thread with is that Andres thought "Greenwich Standard >Time" would get him UTC, or at least something a lot less oddball than >what he got. FWIW, that was just the default on those machines (which in t

Re: 002_types.pl fails on some timezones on windows

2021-10-02 Thread Tom Lane
Thomas Munro writes: > On Sun, Oct 3, 2021 at 9:42 AM Tom Lane wrote: >> * Now-documented decision to map "Greenwich Standard Time" >> to Europe/London, not Atlantic/Reykjavik as they have it. > Hmm. It's hard to pick a default from that set of merged zones, but > the funny thing about this cho

Re: 002_types.pl fails on some timezones on windows

2021-10-02 Thread Thomas Munro
On Sat, Oct 2, 2021 at 1:55 AM Tom Lane wrote: > BTW, I find those "territory" annotations in the CLDR data to be > fascinating. If that corresponds to something that we could retrieve > at runtime, it'd allow far better mapping of Windows zones than we > are doing now. I have no interest in wor

Re: 002_types.pl fails on some timezones on windows

2021-10-02 Thread Thomas Munro
On Sun, Oct 3, 2021 at 9:42 AM Tom Lane wrote: > * Now-documented decision to map "Greenwich Standard Time" > to Europe/London, not Atlantic/Reykjavik as they have it. Hmm. It's hard to pick a default from that set of merged zones, but the funny thing about this choice is that Europe/London is t

Re: 002_types.pl fails on some timezones on windows

2021-10-02 Thread Tom Lane
I wrote: > Oh, thanks for the pointer to CLDR! I tried re-generating our data > based on theirs, and ended up with the attached draft patch. Hearing no objections, pushed after another round of review and a couple more fixes. For the archives' sake, here are the remaining discrepancies between o

Re: 002_types.pl fails on some timezones on windows

2021-10-01 Thread Tom Lane
Andrew Dunstan writes: > On 9/30/21 3:38 PM, Tom Lane wrote: >> But are they running with the prevailing zone set to "Greenwich Standard >> Time"? > drongo's timezone is set to plain "UTC". > It also offers me "UTC+00:00(Dublin, Edinburgh, Lisbon, London)" and > "UTC+00:00(Monrovia, Reykjavik)"

Re: 002_types.pl fails on some timezones on windows

2021-10-01 Thread Andrew Dunstan
On 9/30/21 3:38 PM, Tom Lane wrote: > Andrew Dunstan writes: >> On 9/30/21 2:36 PM, Andres Freund wrote: >>> CI showed me a failure in 002_types.pl on windows. I only just now noticed >>> that because the subscription tests aren't run by any of the vcregress.pl >>> steps :( >> We have windows bu

Re: 002_types.pl fails on some timezones on windows

2021-10-01 Thread Tom Lane
Thomas Munro writes: >> Yes, it's been a while but IIRC Windows in the UK uses confusing >> terminology here even in user interfaces, so that in summer it appears >> to be wrong, which is annoying to anyone brought up on Eggert's >> system. The CLDR windowsZones.xml file shows this. BTW, on clos

Re: 002_types.pl fails on some timezones on windows

2021-09-30 Thread Tom Lane
Thomas Munro writes: > Yes, it's been a while but IIRC Windows in the UK uses confusing > terminology here even in user interfaces, so that in summer it appears > to be wrong, which is annoying to anyone brought up on Eggert's > system. The CLDR windowsZones.xml file shows this. Oh, thanks for t

Re: 002_types.pl fails on some timezones on windows

2021-09-30 Thread Andres Freund
Hi, On 2021-09-30 16:31:33 -0400, Tom Lane wrote: > Andres Freund writes: > > It turns out to be dependant on the current timezone. I have just about zero > > understanding how timezones work on windows, so I can't really interpret why > > that causes a problem on windows, but apparently not on l

Re: 002_types.pl fails on some timezones on windows

2021-09-30 Thread Andres Freund
Hi, On 2021-09-30 16:03:15 -0400, Tom Lane wrote: > I wrote: > > ... sure enough, 002_types.pl > > falls over with TZ=Africa/Casablanca on my Linux machine, too. > > Independently of whether Africa/Casablanca is a sane translation of > that Windows zone name, it'd be nice if 002_types.pl weren't

Re: 002_types.pl fails on some timezones on windows

2021-09-30 Thread Tom Lane
Andres Freund writes: > It turns out to be dependant on the current timezone. I have just about zero > understanding how timezones work on windows, so I can't really interpret why > that causes a problem on windows, but apparently not on linux. As of 20f8671ef, "TZ=Africa/Casablanca make check-wo

Re: 002_types.pl fails on some timezones on windows

2021-09-30 Thread Thomas Munro
On Fri, Oct 1, 2021 at 8:38 AM Tom Lane wrote: > But the option of "Greenwich Daylight Time" suggests that Windows thinks > this means UK civil time, not UTC. Yes, it's been a while but IIRC Windows in the UK uses confusing terminology here even in user interfaces, so that in summer it appears to

Re: 002_types.pl fails on some timezones on windows

2021-09-30 Thread Andres Freund
Hi, On 2021-09-30 15:19:30 -0400, Andrew Dunstan wrote: > On 9/30/21 2:36 PM, Andres Freund wrote: > > Hi, > > > > CI showed me a failure in 002_types.pl on windows. I only just now noticed > > that because the subscription tests aren't run by any of the vcregress.pl > > steps :( > We have window

Re: 002_types.pl fails on some timezones on windows

2021-09-30 Thread Tom Lane
I wrote: > ... sure enough, 002_types.pl > falls over with TZ=Africa/Casablanca on my Linux machine, too. Independently of whether Africa/Casablanca is a sane translation of that Windows zone name, it'd be nice if 002_types.pl weren't so sensitive to the prevailing zone. I looked into exactly why

Re: 002_types.pl fails on some timezones on windows

2021-09-30 Thread Tom Lane
Andrew Dunstan writes: > On 9/30/21 2:36 PM, Andres Freund wrote: >> CI showed me a failure in 002_types.pl on windows. I only just now noticed >> that because the subscription tests aren't run by any of the vcregress.pl >> steps :( > We have windows buildfarm animals running the subscription tes

Re: 002_types.pl fails on some timezones on windows

2021-09-30 Thread Andrew Dunstan
On 9/30/21 2:36 PM, Andres Freund wrote: > Hi, > > CI showed me a failure in 002_types.pl on windows. I only just now noticed > that because the subscription tests aren't run by any of the vcregress.pl > steps :( We have windows buildfarm animals running the subscription tests, e.g.

Re: 002_types.pl fails on some timezones on windows

2021-09-30 Thread Tom Lane
Andres Freund writes: > It turns out to be dependant on the current timezone. I have just about zero > understanding how timezones work on windows, so I can't really interpret why > that causes a problem on windows, but apparently not on linux. Weird. Unless you're using --with-system-tzdata, I