On 2/13/18 18:39, Tom Lane wrote:
> Andres Freund writes:
>> Do we have a policy about catversion bumps for information schema
>> changes? A cluster from before this commit fails the regression tests
>> after the change, but still mostly works...
>
> I think historically we've not bumped catversi
Andres Freund writes:
> Do we have a policy about catversion bumps for information schema
> changes? A cluster from before this commit fails the regression tests
> after the change, but still mostly works...
I think historically we've not bumped catversion, on the grounds that
there's no incompat
On 2018-02-07 10:50:12 -0500, Peter Eisentraut wrote:
> On 2/7/18 00:14, Michael Paquier wrote:
> > On Tue, Feb 06, 2018 at 10:45:52PM -0500, Peter Eisentraut wrote:
> >> I think what I had meant to write was something like
> >>
> >> (t.tgtype & (1 | 66))
> >>
> >> but maybe it's clearer to wri
On Wed, Feb 07, 2018 at 10:50:12AM -0500, Peter Eisentraut wrote:
> Committed with the separate entries.
Thanks. The result looks fine to me.
--
Michael
signature.asc
Description: PGP signature
On 2/7/18 00:14, Michael Paquier wrote:
> On Tue, Feb 06, 2018 at 10:45:52PM -0500, Peter Eisentraut wrote:
>> I think what I had meant to write was something like
>>
>> (t.tgtype & (1 | 66))
>>
>> but maybe it's clearer to write it all out as you did.
>
> If you prefer that, that's fine for m
On Tue, Feb 06, 2018 at 10:45:52PM -0500, Peter Eisentraut wrote:
> I think what I had meant to write was something like
>
> (t.tgtype & (1 | 66))
>
> but maybe it's clearer to write it all out as you did.
If you prefer that, that's fine for me as well. I tend to prefer the
formulation wher
On 2/6/18 17:15, Michael Paquier wrote:
> On Tue, Feb 06, 2018 at 03:16:59PM -0500, Robert Haas wrote:
>> What possible point can there be to such an expression? It's always 0.
>>
>> rhaas=# select distinct tgtype::smallint & 1 & 66 from
>> generate_series(-32768,32767) tgtype;
>> ?column?
>>
On Tue, Feb 06, 2018 at 03:16:59PM -0500, Robert Haas wrote:
> What possible point can there be to such an expression? It's always 0.
>
> rhaas=# select distinct tgtype::smallint & 1 & 66 from
> generate_series(-32768,32767) tgtype;
> ?column?
> --
> 0
> (1 row)
Of course you are
On Tue, Feb 6, 2018 at 2:15 AM, Michael Paquier
wrote:
> Better to use parenthesis for (t.tgtype & 1 & 66) perhaps? You may want
> to comment that this is to filter per row-statement first, and then with
> after/before/instead of, which are what the 1 and the 66 are for.
What possible point can t
On 2/6/18 02:15, Michael Paquier wrote:
>> - CAST(null AS cardinal_number) AS action_order,
>> -- XXX strange hacks follow
>> + CAST(rank() OVER (PARTITION BY n.oid, c.oid, em.num, (t.tgtype &
>> 1 & 66) ORDER BY t.tgname) AS cardinal_number) AS action_order,
>
> B
On Mon, Feb 05, 2018 at 08:59:31PM -0500, Peter Eisentraut wrote:
> Here is a patch that fills in a few more information schema columns, in
> particular those related to the trigger transition tables feature.
It is unfortunate that this cannot be backpatched. Here are few
comments, the logic and
11 matches
Mail list logo