On 2024/11/21 15:43, torikoshia wrote:
Thanks for the update! Agreed.
I think the validator tests related to the on_error option you added are
sufficient.
I've pushed the patch. Thanks!
As for the other file_fdw options, I'm a bit concerned whether it would be
better to add validator tes
On 2024-11-21 00:43, Fujii Masao wrote:
On 2024/11/19 21:40, torikoshia wrote:
These messages may be unexpected for some users because the
documentation of
fild_fdw does not explicitly describe that file_fdw uses COPY
internally.
(I can find several wordings like "as COPY", though.)
However, s
On 2024/11/19 21:40, torikoshia wrote:
These messages may be unexpected for some users because the documentation of
fild_fdw does not explicitly describe that file_fdw uses COPY internally.
(I can find several wordings like "as COPY", though.)
However, since the current file_fdw already has suc
On 2024-11-13 23:17, Yugo NAGATA wrote:
On Wed, 13 Nov 2024 21:48:10 +0900
torikoshia wrote:
On 2024-11-12 14:51, Yugo Nagata wrote:
Thanks for your review!
> On Tue, 12 Nov 2024 10:16:50 +0900
> torikoshia wrote:
>
>> On 2024-11-12 01:49, Fujii Masao wrote:
>> > On 2024/11/11 21:45, toriko
On Wed, 13 Nov 2024 21:48:10 +0900
torikoshia wrote:
> On 2024-11-12 14:51, Yugo Nagata wrote:
>
> Thanks for your review!
>
> > On Tue, 12 Nov 2024 10:16:50 +0900
> > torikoshia wrote:
> >
> >> On 2024-11-12 01:49, Fujii Masao wrote:
> >> > On 2024/11/11 21:45, torikoshia wrote:
> >> >>> Tha
On 2024-11-12 14:51, Yugo Nagata wrote:
Thanks for your review!
On Tue, 12 Nov 2024 10:16:50 +0900
torikoshia wrote:
On 2024-11-12 01:49, Fujii Masao wrote:
> On 2024/11/11 21:45, torikoshia wrote:
>>> Thanks for adding the comment. It clearly states that REJECT_LIMIT
>>> can be
>>> a single
On 2024-11-12 15:23, Kirill Reshke wrote:
Thanks for your review!
On Tue, 12 Nov 2024 at 06:17, torikoshia
wrote:
On 2024-11-12 01:49, Fujii Masao wrote:
> On 2024/11/11 21:45, torikoshia wrote:
>>> Thanks for adding the comment. It clearly states that REJECT_LIMIT
>>> can be
>>> a single-qu
On Tue, 12 Nov 2024 at 06:17, torikoshia wrote:
>
> On 2024-11-12 01:49, Fujii Masao wrote:
> > On 2024/11/11 21:45, torikoshia wrote:
> >>> Thanks for adding the comment. It clearly states that REJECT_LIMIT
> >>> can be
> >>> a single-quoted string. However, it might also be helpful to mention
>
On Tue, 12 Nov 2024 10:16:50 +0900
torikoshia wrote:
> On 2024-11-12 01:49, Fujii Masao wrote:
> > On 2024/11/11 21:45, torikoshia wrote:
> >>> Thanks for adding the comment. It clearly states that REJECT_LIMIT
> >>> can be
> >>> a single-quoted string. However, it might also be helpful to menti
On 2024-11-12 01:49, Fujii Masao wrote:
On 2024/11/11 21:45, torikoshia wrote:
Thanks for adding the comment. It clearly states that REJECT_LIMIT
can be
a single-quoted string. However, it might also be helpful to mention
that
it can be provided as an int64 in the COPY command option. How abou
On 2024/11/11 21:45, torikoshia wrote:
Thanks for adding the comment. It clearly states that REJECT_LIMIT can be
a single-quoted string. However, it might also be helpful to mention that
it can be provided as an int64 in the COPY command option. How about
updating it like this?
--
On 2024-11-08 01:44, Fujii Masao wrote:
Thanks for your review!
On 2024/11/05 22:30, torikoshia wrote:
Thanks for the patch! Could you add it to the next CommitFest?
Added an entry for this patch:
https://commitfest.postgresql.org/50/5331/
Thanks!
+ALTER FOREIGN TABLE agg_bad OPTIONS (re
On 2024/11/05 22:30, torikoshia wrote:
Thanks for the patch! Could you add it to the next CommitFest?
Added an entry for this patch:
https://commitfest.postgresql.org/50/5331/
Thanks!
+ALTER FOREIGN TABLE agg_bad OPTIONS (reject_limit '1');
+SELECT * FROM agg_bad;
+ a | b
+-+---
On 2024-10-18 01:51, Fujii Masao wrote:
Thanks for your review and sorry for my late reply.
On 2024/10/17 22:45, torikoshia wrote:
Hi,
4ac2a9bec introduced reject_limit option to the COPY command, and I
was wondering if it might be beneficial to add the same option to
file_fdw.
Although th
On 2024/10/17 22:45, torikoshia wrote:
Hi,
4ac2a9bec introduced reject_limit option to the COPY command, and I was
wondering if it might be beneficial to add the same option to file_fdw.
Although there may be fewer practical use cases compared to COPY, it could
still be useful in situation
15 matches
Mail list logo
