Re: BUG #16346: pg_upgrade fails on a trigger with a comment

2020-04-08 Thread Hamid Akhtar
I have tested the patch in a little more detail. (1) Verified that it fixes the bug (2) Ran regression tests; all are passing. To recap, the attached patch moves restoration of comments to the RESTORE_PASS_POST_ACL. This ensures that comments are restored in a PASS when essentially all required ob

Re: BUG #16346: pg_upgrade fails on a trigger with a comment

2020-04-07 Thread Hamid Akhtar
As you have mentioned, I have verified that indeed commit 4c40b27b broke this. In this particular commit moves restoration of materialized views and event triggers to the last phase. Perhaps, comments should also be moved to this phase as there may comments on either of these types of objects. At