Re: Bogus bitmasking in heap2_desc

2025-07-28 Thread Michael Paquier
On Mon, Jul 28, 2025 at 01:31:15PM +0800, Julien Rouhaud wrote: > Ah I'm the one apologizing, I totally missed that comment. > > Thanks for the pointing it out. Thanks, no problem. -- Michael signature.asc Description: PGP signature

Re: Bogus bitmasking in heap2_desc

2025-07-27 Thread Julien Rouhaud
Hi, On Mon, Jul 28, 2025 at 02:27:43PM +0900, Michael Paquier wrote: > > The relationship between XLOG_HEAP_OPMASK and heap2 is documented in > heapam_xlog.h. XLOG_HEAP2_MULTI_INSERT may have XLOG_HEAP_INIT_PAGE > set, so if we don't filter the contents from XLogRecGetInfo() then the > record des

Re: Bogus bitmasking in heap2_desc

2025-07-27 Thread Michael Paquier
On Sun, Jul 27, 2025 at 05:19:56PM +0800, Julien Rouhaud wrote: > heap2_desc apparently inherited the extra bit filtering from heap_desc to > ignore XLOG_HEAP_INIT_PAGE. But XLOG_HEAP2 only has real opcodes in the > high bits there is no reason why there should be this filtering, and even if > it