Re: Checkpointer write combining

2025-09-20 Thread Chao Li
> On Sep 10, 2025, at 01:55, Melanie Plageman wrote: > > > [1] > https://www.postgresql.org/message-id/flat/CAAKRu_Yjn4mvN9NBxtmsCQSGwup45CoA4e05nhR7ADP-v0WCig%40mail.gmail.com > 1 - 0001 ``` --- a/src/backend/storage/buffer/freelist.c +++ b/src/backend/storage/buffer/freelist.c + * The b

Re: Checkpointer write combining

2025-09-19 Thread Melanie Plageman
On Tue, Sep 9, 2025 at 9:27 AM Nazir Bilal Yavuz wrote: > Thanks for the review! > From 053dd9d15416d76ce4b95044d848f51ba13a2d20 Mon Sep 17 00:00:00 2001 > From: Melanie Plageman > Date: Tue, 2 Sep 2025 11:00:44 -0400 > Subject: [PATCH v2 1/9] Refactor goto into for loop in GetVictimBuffer() >

Re: Checkpointer write combining

2025-09-11 Thread Chao Li
> On Sep 12, 2025, at 07:11, Melanie Plageman wrote: > > On Wed, Sep 10, 2025 at 4:24 AM Chao Li wrote: >> > > Thanks for the review! > > For any of your feedback that I simply implemented, I omitted an > inline comment about it. Those changes are included in the attached > v6. My inline re

Re: Checkpointer write combining

2025-09-11 Thread Melanie Plageman
On Wed, Sep 10, 2025 at 4:24 AM Chao Li wrote: > Thanks for the review! For any of your feedback that I simply implemented, I omitted an inline comment about it. Those changes are included in the attached v6. My inline replies below are only for feedback requiring more discussion. > On Sep 10,

Re: Checkpointer write combining

2025-09-09 Thread Jeff Davis
On Tue, 2025-09-09 at 13:55 -0400, Melanie Plageman wrote: > On Tue, Sep 9, 2025 at 11:16 AM Melanie Plageman > wrote: > > > > One more fix and a bit more cleanup in attached v4. > > Okay one more version: I updated the thread on eager flushing the > bulkwrite ring [1], and some updates were nee

Re: Checkpointer write combining

2025-09-09 Thread Melanie Plageman
On Tue, Sep 9, 2025 at 11:16 AM Melanie Plageman wrote: > > One more fix and a bit more cleanup in attached v4. Okay one more version: I updated the thread on eager flushing the bulkwrite ring [1], and some updates were needed here. - Melanie [1] https://www.postgresql.org/message-id/flat/CAAK

Re: Checkpointer write combining

2025-09-09 Thread Melanie Plageman
On Tue, Sep 9, 2025 at 9:39 AM Melanie Plageman wrote: > > Oops, you're right. v3 attached with that mistake fixed. One more fix and a bit more cleanup in attached v4. - Melanie From fef00f5bd61dc0e3cac95fa39a75b3d73ba7d0a6 Mon Sep 17 00:00:00 2001 From: Melanie Plageman Date: Tue, 2 Sep 2025 1

Re: Checkpointer write combining

2025-09-09 Thread Nazir Bilal Yavuz
Hi, Thank you for working on this! On Tue, 9 Sept 2025 at 02:44, Melanie Plageman wrote: > > On Tue, Sep 2, 2025 at 5:10 PM Melanie Plageman > wrote: > > > > The attached patchset implements checkpointer write combining -- which > > makes immediate checkpoints at least 20% faster in my tests. >

Re: Checkpointer write combining

2025-09-08 Thread Melanie Plageman
On Tue, Sep 2, 2025 at 5:10 PM Melanie Plageman wrote: > > The attached patchset implements checkpointer write combining -- which > makes immediate checkpoints at least 20% faster in my tests. > Checkpointer achieves higher write throughput and higher write IOPs > with the patch. These needed a r