Re: Correction of RowMark Removal During Sel-Join Elimination

2025-09-02 Thread Andrei Lepikhov
On 31/8/2025 03:03, Richard Guo wrote: On Sun, Aug 31, 2025 at 9:50 AM Alexander Korotkov wrote: On Sun, Aug 31, 2025 at 2:51 AM Richard Guo wrote: I think it's better to push this patch sooner rather than later, as multiple people have encountered the issue in different ways. I'll go ahead

Re: Correction of RowMark Removal During Sel-Join Elimination

2025-08-30 Thread Richard Guo
On Sun, Aug 31, 2025 at 9:50 AM Alexander Korotkov wrote: > On Sun, Aug 31, 2025 at 2:51 AM Richard Guo wrote: > > I think it's better to push this patch sooner rather than later, as > > multiple people have encountered the issue in different ways. I'll go > > ahead and push 0001 from my patch s

Re: Correction of RowMark Removal During Sel-Join Elimination

2025-08-30 Thread Alexander Korotkov
On Sun, Aug 31, 2025 at 2:51 AM Richard Guo wrote: > On Sun, Aug 31, 2025 at 8:41 AM Richard Guo wrote: > > On Sun, Aug 31, 2025 at 8:12 AM Alexander Korotkov > > wrote: > > > The same patch with a bit revised comment and commit message. > > > FWIW, I reported this same issue and proposed the p

Re: Correction of RowMark Removal During Sel-Join Elimination

2025-08-30 Thread Richard Guo
On Sun, Aug 31, 2025 at 8:41 AM Richard Guo wrote: > On Sun, Aug 31, 2025 at 8:12 AM Alexander Korotkov > wrote: > > The same patch with a bit revised comment and commit message. > FWIW, I reported this same issue and proposed the patch last week in > Discussion: > https://postgr.es/m/CAMbWs48

Re: Correction of RowMark Removal During Sel-Join Elimination

2025-08-30 Thread Richard Guo
On Sun, Aug 31, 2025 at 8:12 AM Alexander Korotkov wrote: > > The draft patch fixing this is attached. I will continue the investigation. > > The same patch with a bit revised comment and commit message. FWIW, I reported this same issue and proposed the patch last week in Discussion: https://po

Re: Correction of RowMark Removal During Sel-Join Elimination

2025-08-30 Thread Alexander Korotkov
On Sat, Aug 30, 2025 at 10:29 PM Alexander Korotkov wrote: > On Sat, Aug 30, 2025 at 9:54 PM Alexander Korotkov > wrote: > > On Sat, Aug 30, 2025 at 4:00 PM Alexander Lakhin > > wrote: > > > > > > Hello Alexander, > > > > > > 24.08.2025 03:44, Alexander Korotkov wrote: > > > > > > Thank you fo

Re: Correction of RowMark Removal During Sel-Join Elimination

2025-08-30 Thread Alexander Korotkov
On Sat, Aug 30, 2025 at 9:54 PM Alexander Korotkov wrote: > On Sat, Aug 30, 2025 at 4:00 PM Alexander Lakhin wrote: > > > > Hello Alexander, > > > > 24.08.2025 03:44, Alexander Korotkov wrote: > > > > Thank you for catching this. And thank you for the fix. I think it > > worth separating fix an

Re: Correction of RowMark Removal During Sel-Join Elimination

2025-08-30 Thread Alexander Korotkov
On Sat, Aug 30, 2025 at 4:00 PM Alexander Lakhin wrote: > > Hello Alexander, > > 24.08.2025 03:44, Alexander Korotkov wrote: > > Thank you for catching this. And thank you for the fix. I think it > worth separating fix and refactoring. This helps to understand what > exactly the fix is by looki

Re: Correction of RowMark Removal During Sel-Join Elimination

2025-08-30 Thread Alexander Lakhin
Hello Alexander, 24.08.2025 03:44, Alexander Korotkov wrote: Thank you for catching this. And thank you for the fix. I think it worth separating fix and refactoring. This helps to understand what exactly the fix is by looking at the patch. I also edited commit message. I'm going to push thi

Re: Correction of RowMark Removal During Sel-Join Elimination

2025-08-23 Thread Alexander Korotkov
Hi, Andrei! On Tue, Aug 12, 2025 at 12:40 PM Andrei Lepikhov wrote: > On 11/8/2025 20:15, Greg Sabino Mullane wrote: > > I'm not convinced this is an improvement from someone just coming in to > > this part of the code, especially given (for example) the comment right > > above it: > > > > * De

Re: Correction of RowMark Removal During Sel-Join Elimination

2025-08-12 Thread Andrei Lepikhov
On 11/8/2025 20:15, Greg Sabino Mullane wrote: I'm not convinced this is an improvement from someone just coming in to this part of the code, especially given (for example) the comment right above it:  * Determine if the inner table can duplicate outer rows.  We must  * bypass the unique rel

Re: Correction of RowMark Removal During Sel-Join Elimination

2025-08-11 Thread Greg Sabino Mullane
Basic concept looks good. However: and fixes the incorrect behaviour. Additionally, it renames variables to > make > similar errors more apparent in the future. - if (!innerrel_is_unique_ext(root, joinrelids, inner->relids, > - outer, JOIN_INNER, selfjoinquals, > + if (!innerrel_is_unique_ext(ro