On Tue, Dec 16, 2025 at 12:51 PM jian he <[email protected]> wrote: > > hi. > > Following the addition of error position support to ComputePartitionAttrs in > [0], we can extend this feature to ComputeIndexAttrs. > > Both partition keys and indexes support expressions and share a 32-column > limit, CREATE INDEX can be as complicated as PARTITION BY expression, and > given > that ComputeIndexAttrs already contains 14 calls to ereport(ERROR, ...). > Adding error position support for ComputeIndexAttrs seems to make sense. > > To achieve this, ComputeIndexAttrs must receive a ParseState. Since > ComputeIndexAttrs is nested under DefineIndex , DefineIndex must also have a > ParseState. > > v1-0001: almost the same as [1], the only difference is after > makeNode(IndexElem), > we should set the location to -1. > v1-0002: Error position support for ComputeIndexAttrs >
+1, patch looks quite straightforward and pretty much reasonable to me. Regards, Amul
