Re: Fix wrong filename in header comment of gin_tuple.h

2025-10-18 Thread Chao Li
> On Sep 23, 2025, at 04:02, David Rowley wrote: > > On Mon, 22 Sept 2025 at 14:46, Chao Li wrote: >> diff --git a/src/backend/rewrite/rowsecurity.c >> b/src/backend/rewrite/rowsecurity.c > >> - * rewrite/rowsecurity.c >> + * rowsecurity.c > >> + * >> + * IDENTIFICATION >> + *src/backen

Re: Fix wrong filename in header comment of gin_tuple.h

2025-09-22 Thread David Rowley
On Tue, 23 Sept 2025 at 10:21, Chao Li wrote: > My script just scan all .c and .h files and extract one-line filename and > file path from header comments. If they don’t equal to either pure filename > or file path relative to repo root, then capture it. And rowsecurity.c was > the only capture

Re: Fix wrong filename in header comment of gin_tuple.h

2025-09-22 Thread David Rowley
On Mon, 22 Sept 2025 at 14:46, Chao Li wrote: > diff --git a/src/backend/rewrite/rowsecurity.c > b/src/backend/rewrite/rowsecurity.c > - * rewrite/rowsecurity.c > + * rowsecurity.c > + * > + * IDENTIFICATION > + *src/backend/rewrite/rowsecurity.c I don't what's incorrect with these as I'm

Re: Fix wrong filename in header comment of gin_tuple.h

2025-09-21 Thread Chao Li
I quickly created a Python script and captured one more in rewrite/rowsecurity.c. The file put filename reference in a different format than other files: ``` diff --git a/src/backend/rewrite/rowsecurity.c b/src/backend/rewrite/rowsecurity.c index 4dad384d04d..3d6b6ba177b 100644 --- a/src/backend/r

Re: Fix wrong filename in header comment of gin_tuple.h

2025-09-21 Thread David Rowley
On Mon, 22 Sept 2025 at 12:57, Richard Guo wrote: > > On Mon, Sep 22, 2025 at 9:53 AM David Rowley wrote: > > I was just working on a script to find others and it highlighted a > > bunch more. Do you still want to do this one, or should I take them > > all in one fell swoop? > > Makes sense to ha

Re: Fix wrong filename in header comment of gin_tuple.h

2025-09-21 Thread Richard Guo
On Mon, Sep 22, 2025 at 9:53 AM David Rowley wrote: > On Mon, 22 Sept 2025 at 11:59, Richard Guo wrote: > > On Mon, Sep 22, 2025 at 8:10 AM Chao Li wrote: > > > When gin_tuple.h was introduced by commit 8492feb[1], the file header > > > comment incorrectly referred to gin.h. Update the comment

Re: Fix wrong filename in header comment of gin_tuple.h

2025-09-21 Thread David Rowley
On Mon, 22 Sept 2025 at 11:59, Richard Guo wrote: > > On Mon, Sep 22, 2025 at 8:10 AM Chao Li wrote: > > When gin_tuple.h was introduced by commit 8492feb[1], the file header > > comment incorrectly referred to gin.h. Update the comment to mention > > gin_tuple.h instead. > > Indeed. Will push

Re: Fix wrong filename in header comment of gin_tuple.h

2025-09-21 Thread Richard Guo
On Mon, Sep 22, 2025 at 8:10 AM Chao Li wrote: > When gin_tuple.h was introduced by commit 8492feb[1], the file header comment > incorrectly referred to gin.h. Update the comment to mention gin_tuple.h > instead. Indeed. Will push the patch. - Richard