Re: Fixed a typo in comment in compress_lz4.c

2025-10-18 Thread Chao Li
> On Oct 14, 2025, at 08:12, Tom Lane wrote: > > Chao Li writes: >> Look at this instance. The comment says: > >> * LZ4 equivalent to feof() or gzeof(). Return true iff there is no >> * more buffered data and the end of the input file has been reached. > >> It just states when the functio

Re: Fixed a typo in comment in compress_lz4.c

2025-10-17 Thread Tom Lane
Daniel Gustafsson writes: >> On 13 Oct 2025, at 23:25, Chao Li wrote: >> Fixed a typo: "iff" -> "if" that I found while reviewing the other patch. > iff is shorthand for "if and only if", so it is correct here. That being > said, > it's also the cause of many typofix suggstions so it's clearly

Re: Fixed a typo in comment in compress_lz4.c

2025-10-13 Thread Tom Lane
Chao Li writes: > Look at this instance. The comment says: > * LZ4 equivalent to feof() or gzeof(). Return true iff there is no > * more buffered data and the end of the input file has been reached. > It just states when the function should return true. In this case, why “if” > is not good

Re: Fixed a typo in comment in compress_lz4.c

2025-10-13 Thread Chao Li
> On Oct 14, 2025, at 07:32, Michael Paquier wrote: > > On Mon, Oct 13, 2025 at 06:08:43PM -0400, Tom Lane wrote: >> I disagree that it's not widely known. OneLook Dictionary Search [1] >> defines it correctly as "Usually means: If and only if; equivalence" >> and reports finding it in 35 of t

Re: Fixed a typo in comment in compress_lz4.c

2025-10-13 Thread Michael Paquier
On Mon, Oct 13, 2025 at 06:08:43PM -0400, Tom Lane wrote: > I disagree that it's not widely known. OneLook Dictionary Search [1] > defines it correctly as "Usually means: If and only if; equivalence" > and reports finding it in 35 of their underlying dictionaries, > including all the usual suspect

Re: Fixed a typo in comment in compress_lz4.c

2025-10-13 Thread Chao Li
> On Oct 14, 2025, at 05:31, Daniel Gustafsson wrote: > >> On 13 Oct 2025, at 23:25, Chao Li wrote: > >> Fixed a typo: "iff" -> "if" that I found while reviewing the other patch. > > iff is shorthand for "if and only if", so it is correct here. That being > said, > it's also the cause of m

Re: Fixed a typo in comment in compress_lz4.c

2025-10-13 Thread Daniel Gustafsson
> On 13 Oct 2025, at 23:25, Chao Li wrote: > Fixed a typo: "iff" -> "if" that I found while reviewing the other patch. iff is shorthand for "if and only if", so it is correct here. That being said, it's also the cause of many typofix suggstions so it's clearly not widely known anymore and we tr