On 03.09.25 19:14, Nathan Bossart wrote:
I noticed that "make maintainer-clean" doesn't remove
src/include/utils/guc_tables.inc.c. This seems to fix it:
Thanks, fixed. (I moved the rule to a different line so it's closer to
related files. But it's the same thing.)
I noticed that "make maintainer-clean" doesn't remove
src/include/utils/guc_tables.inc.c. This seems to fix it:
diff --git a/src/include/Makefile b/src/include/Makefile
index 3f94543f327..58eb6da27fe 100644
--- a/src/include/Makefile
+++ b/src/include/Makefile
@@ -74,7 +74,7 @@ uninstall:
clean:
On 03.09.25 11:39, Richard Guo wrote:
On Wed, Sep 3, 2025 at 5:41 PM Peter Eisentraut wrote:
I have committed this with a few of the small changes mentioned nearby.
copperhead reported just now a test failure in test_oat_hooks:
SET debug_discard_caches = 0;
+ERROR: unrecognized configurat
On Wed, Sep 3, 2025 at 5:41 PM Peter Eisentraut wrote:
> I have committed this with a few of the small changes mentioned nearby.
copperhead reported just now a test failure in test_oat_hooks:
SET debug_discard_caches = 0;
+ERROR: unrecognized configuration parameter "debug_discard_caches"
I'm
> On 3 Sep 2025, at 10:37, Peter Eisentraut wrote:
>
> On 28.08.25 15:29, Daniel Gustafsson wrote:
>>> On 28 Aug 2025, at 08:53, Peter Eisentraut wrote:
>>> I addressed all those, and did another cleanup pass over the script. (The
>>> formatting is from pgperltidy.)
>> A tiny nitpick is that a
On 01.09.25 09:21, John Naylor wrote:
On Thu, Aug 28, 2025 at 1:53 PM Peter Eisentraut wrote:
Ok, good suggestions. I addressed all those, and did another cleanup
pass over the script. (The formatting is from pgperltidy.)
I have no further comments on v3.
I have committed this with a few
On 28.08.25 20:03, David E. Wheeler wrote:
On Aug 28, 2025, at 09:29, Daniel Gustafsson wrote:
A tiny nitpick is that all the other generator scripts (that I looked at) in
the tree use GetOptions() with named parameter rather than dereference ARGV
directly:
+my $input_fname = $ARGV[0];
+my $o
On 28.08.25 15:29, Daniel Gustafsson wrote:
On 28 Aug 2025, at 08:53, Peter Eisentraut wrote:
I addressed all those, and did another cleanup pass over the script. (The
formatting is from pgperltidy.)
A tiny nitpick is that all the other generator scripts (that I looked at) in
the tree use
Hi John,
On Sep 1, 2025, at 03:21, John Naylor wrote:
> I find the loop over @parse a lot less readable this way.
Yeah, that’s the trade-off. Probably not worth it to reduce legibility.
>> * Use the /r regex return sequence to simplify dquote() (requires Perl 5.14,
>> IIRC)
>
> I think our p
On Thu, Aug 28, 2025 at 1:53 PM Peter Eisentraut wrote:
> Ok, good suggestions. I addressed all those, and did another cleanup
> pass over the script. (The formatting is from pgperltidy.)
I have no further comments on v3.
On Fri, Aug 29, 2025 at 1:03 AM David E. Wheeler wrote:
> And since I g
On Aug 28, 2025, at 09:29, Daniel Gustafsson wrote:
> A tiny nitpick is that all the other generator scripts (that I looked at) in
> the tree use GetOptions() with named parameter rather than dereference ARGV
> directly:
>
> +my $input_fname = $ARGV[0];
> +my $output_fname = $ARGV[1];
GetOption
> On 28 Aug 2025, at 08:53, Peter Eisentraut wrote:
> I addressed all those, and did another cleanup pass over the script. (The
> formatting is from pgperltidy.)
A tiny nitpick is that all the other generator scripts (that I looked at) in
the tree use GetOptions() with named parameter rather t
On Mon, Aug 25, 2025 at 4:36 PM Peter Eisentraut wrote:
>
> Here is an updated patch with the remaining comments carried over. I'm
> not sure how I lost these. I also added some more comments to the Perl
> script and have it print the usual boilerplate into the header. And I
> added some .gitig
On Wed, Aug 20, 2025 at 3:18 AM Peter Eisentraut wrote:
> Ok, I did the big conversion, and tidied everything up so that it now
> generates the big tables in guc_tables.c from the .dat file. This
> basically works now.
> - One thing I didn't reproduce in the generated code is the line breaks
> i
On 8/11/25 12:46, David E. Wheeler wrote:
On Aug 11, 2025, at 02:04, Peter Eisentraut wrote:
My next goal would be to make this work so that most of
guc_tables.c is generated, and nothing else changes beyond that.
But before I do all the remaining tedious work, I wanted to check
what people thi
On Aug 11, 2025, at 02:04, Peter Eisentraut wrote:
> My next goal would be to make this work so that most of guc_tables.c is
> generated, and nothing else changes beyond that. But before I do all the
> remaining tedious work, I wanted to check what people think.
Honestly it seems like a no-br
16 matches
Mail list logo
