On Tue, Nov 05, 2019 at 01:41:28PM -0500, Tom Lane wrote:
> Pushed like that, then.
Thanks for the commit.
--
Michael
signature.asc
Description: PGP signature
Michael Paquier writes:
> On Mon, Nov 04, 2019 at 03:31:27PM -0500, Tom Lane wrote:
>> I'd rather do something like the attached, which makes it more of an
>> explicit goal that we won't fail on bad input. (As written, we'd only
>> fail on bad classId, which is a case that really shouldn't happen
On Mon, Nov 04, 2019 at 03:31:27PM -0500, Tom Lane wrote:
> I'd rather do something like the attached, which makes it more of an
> explicit goal that we won't fail on bad input. (As written, we'd only
> fail on bad classId, which is a case that really shouldn't happen.)
Okay, that part looks fine
Michael Paquier writes:
> Okay. Attached is what I was thinking about, with extra regression
> tests to cover the ground for toast tables and indexes that are able
> to reproduce the original failure, and more comments for the routines
> as they should be used only for ACL error messages.
I'd ra
On Fri, Oct 04, 2019 at 05:55:40PM +0900, Michael Paquier wrote:
> On Thu, Oct 03, 2019 at 09:52:34AM -0400, Tom Lane wrote:
>> FWIW, I really dislike this patch, mainly because it is based on the
>> assumption (as John said) that get_relkind_objtype is used only
>> in aclcheck_error calls. Howev
On Thu, Oct 03, 2019 at 09:52:34AM -0400, Tom Lane wrote:
> FWIW, I really dislike this patch, mainly because it is based on the
> assumption (as John said) that get_relkind_objtype is used only
> in aclcheck_error calls. However it's not obvious why that should
> be true, and there certainly is
Michael Paquier writes:
> On Tue, Oct 01, 2019 at 12:10:50AM +, Hsu, John wrote:
>> get_relkind_objtype(...) was introduced as part of 8b9e9644dc, and it
>> doesn't include
>> RELKIND_TOASTVALUE. As a result when a user who has usage rights on schema
>> pg_toast
>> and attempts to reindex a
On Tue, Oct 01, 2019 at 12:10:50AM +, Hsu, John wrote:
> get_relkind_objtype(...) was introduced as part of 8b9e9644dc, and it doesn't
> include
> RELKIND_TOASTVALUE. As a result when a user who has usage rights on schema
> pg_toast
> and attempts to reindex a table it is not the owner of it
