Re: Issue with logical replication slot during switchover

2025-09-01 Thread Fabrice Chapuis
Hi, I will make de modifications based on the remarks you mentioned. Regards, Fabrice On Mon, Sep 1, 2025 at 5:45 AM shveta malik wrote: > On Sat, Aug 30, 2025 at 11:43 AM Shlok Kyal > wrote: > > > > Hi Fabrice, > > > > Thanks for providing the patch. I reviewed your patch and have > > follow

Re: Issue with logical replication slot during switchover

2025-08-31 Thread shveta malik
On Sat, Aug 30, 2025 at 11:43 AM Shlok Kyal wrote: > > Hi Fabrice, > > Thanks for providing the patch. I reviewed your patch and have > following comment: > > 1. I think we should add a commit message in the patch. It would help > to give an understanding of the patch. > > 2. I tried applying patc

Re: Issue with logical replication slot during switchover

2025-08-29 Thread Shlok Kyal
On Fri, 29 Aug 2025 at 19:28, Fabrice Chapuis wrote: > > Thanks Shveta for your procedure to follow, here is the version 1 of the patch > > Regards, > > Fabrice > > On Fri, Aug 29, 2025 at 5:34 AM shveta malik wrote: >> >> On Thu, Aug 28, 2025 at 9:11 PM Fabrice Chapuis >> wrote: >> > >> > What

Re: Issue with logical replication slot during switchover

2025-08-29 Thread Fabrice Chapuis
Thanks Shveta for your procedure to follow, here is the version 1 of the patch Regards, Fabrice On Fri, Aug 29, 2025 at 5:34 AM shveta malik wrote: > On Thu, Aug 28, 2025 at 9:11 PM Fabrice Chapuis > wrote: > > > > What is the procedure to create this patch. Thank you for your help. > > > > W

Re: Issue with logical replication slot during switchover

2025-08-28 Thread shveta malik
On Thu, Aug 28, 2025 at 9:11 PM Fabrice Chapuis wrote: > > What is the procedure to create this patch. Thank you for your help. > We use 'git format-patch' to generate formatted patches. I have given a few links ([1],[2],[3)] on know-how. I usually use these steps: git add git add git c

Re: Issue with logical replication slot during switchover

2025-08-28 Thread Fabrice Chapuis
What is the procedure to create this patch. Thank you for your help. On Thu, Aug 28, 2025 at 12:04 PM shveta malik wrote: > On Wed, Aug 27, 2025 at 7:55 PM Fabrice Chapuis > wrote: > > > > For the first step (a), the pg_create_logical_replication_slot interface > is extended. > > The slot on th

Re: Issue with logical replication slot during switchover

2025-08-28 Thread shveta malik
On Wed, Aug 27, 2025 at 7:55 PM Fabrice Chapuis wrote: > > For the first step (a), the pg_create_logical_replication_slot interface is > extended. > The slot on the new attached standby will be dropped and recreated if the > flag allow_overwrite is set to true. > I tested the modified source, co

Re: Issue with logical replication slot during switchover

2025-08-27 Thread Fabrice Chapuis
For the first step (a), the pg_create_logical_replication_slot interface is extended. The slot on the new attached standby will be dropped and recreated if the flag allow_overwrite is set to true. I tested the modified source, could you please give me a feedback on code changes. Regards, Fabrice

Re: Issue with logical replication slot during switchover

2025-08-14 Thread Fabrice Chapuis
I'll work on pg_create_logical_replication_slot() API. pg_replication_slots view must also be adjusted to display the new flag allow_overwrite. Regards Fabrice On Thu, Aug 14, 2025 at 8:07 AM shveta malik wrote: > On Wed, Aug 13, 2025 at 9:29 PM Fabrice Chapuis > wrote: > > > > Thanks for sha

Re: Issue with logical replication slot during switchover

2025-08-13 Thread shveta malik
On Wed, Aug 13, 2025 at 9:29 PM Fabrice Chapuis wrote: > > Thanks for sharing this. In fact, I agree, introducing an allow_overwrite > slot property makes seems cleaner than a GUC for this specific use case. > > a) At first, an extension of pg_create_logical_replication_slot() could be > propos

Re: Issue with logical replication slot during switchover

2025-08-13 Thread Fabrice Chapuis
Thanks for sharing this. In fact, I agree, introducing an allow_overwrite slot property makes seems cleaner than a GUC for this specific use case. a) At first, an extension of pg_create_logical_replication_slot() could be proposed b) pg_alter_logical_replication_slot(): that could be is a neat app

Re: Issue with logical replication slot during switchover

2025-08-12 Thread shveta malik
On Fri, Aug 8, 2025 at 7:01 PM Fabrice Chapuis wrote: > > Thanks Shveta for coming on this point again and fixing the link. > The idea is to check if the slot has same name to try to resynchronize it > with the primary. > ok the check on the failover status for the remote slot is perhaps redundan

Re: Issue with logical replication slot during switchover

2025-08-08 Thread Fabrice Chapuis
Thanks Shveta for coming on this point again and fixing the link. The idea is to check if the slot has same name to try to resynchronize it with the primary. ok the check on the failover status for the remote slot is perhaps redundant. I'm not sure what impact setting the synced flag to true might

Re: Issue with logical replication slot during switchover

2025-08-07 Thread shveta malik
On Thu, Aug 7, 2025 at 6:50 PM Fabrice Chapuis wrote: > > Hi, > > An issue occurred during the initial switchover using PostgreSQL version > 17.5. The setup consists of a cluster with two nodes, managed by Patroni > version 4.0.5. > Logical replication is configured on the same instance, and the