Re: Move the "DR_intorel" struct to a more suitable position

2022-03-15 Thread Julien Rouhaud
Hi, On Wed, Mar 16, 2022 at 11:16:58AM +0800, zk.wang wrote: > Generally, we should define struct in the header file(.h). But I found struct > "DR_intorel" in createas.c and it doesn't seem to be properly defined. May be > it should define in createas.h. We put struct declarations in header files

Re: Move the "DR_intorel" struct to a more suitable position

2022-03-15 Thread Andres Freund
Hi, On March 15, 2022 8:16:58 PM PDT, "zk.wang" wrote: >Generally, we should define struct in the header file(.h). Why? It's perfectly sensible to define types in .c files when they're not used elsewhere. Greetings, Andres -- Sent from my Android device with K-9 Mail. Please excuse my brevi