Re: PG 18 relnotes and RC1

2025-08-31 Thread Bruce Momjian
On Sun, Aug 31, 2025 at 08:51:40PM +0200, Peter Eisentraut wrote: > On 31.08.25 16:34, Tom Lane wrote: > > I think our past practice has been to list any one item either in > > Migration or the following sections, not in both places. This item > > seems to adhere to that too: I don't see that comm

Re: PG 18 relnotes and RC1

2025-08-31 Thread Peter Eisentraut
On 31.08.25 16:34, Tom Lane wrote: I think our past practice has been to list any one item either in Migration or the following sections, not in both places. This item seems to adhere to that too: I don't see that commit hash anywhere else. So I'm not clear why you're finding this duplicative?

Re: PG 18 relnotes and RC1

2025-08-31 Thread Bruce Momjian
On Sun, Aug 31, 2025 at 10:34:43AM -0400, Tom Lane wrote: > Peter Eisentraut writes: > > On 30.08.25 18:52, Tom Lane wrote: > >> I suppose that the expectation is that every release note item > >> will be credited to someone. Why does this item lack a credit? > > > Maybe I'm understanding this d

Re: PG 18 relnotes and RC1

2025-08-31 Thread Bruce Momjian
On Sun, Aug 31, 2025 at 01:34:26PM +0200, Peter Eisentraut wrote: > On 30.08.25 18:52, Tom Lane wrote: > > Bruce Momjian writes: > > > Second, the release note item added by this commit: > > > commit d1073c3b4cc > > > Author: Peter Eisentraut > > > Date: Fri Aug 29 10:18:10 2025 +0200 > >

Re: PG 18 relnotes and RC1

2025-08-31 Thread Tom Lane
Peter Eisentraut writes: > On 30.08.25 18:52, Tom Lane wrote: >> I suppose that the expectation is that every release note item >> will be credited to someone. Why does this item lack a credit? > Maybe I'm understanding this differently, but the "Migration" section > ought to be advice about th

Re: PG 18 relnotes and RC1

2025-08-31 Thread Peter Eisentraut
On 30.08.25 18:52, Tom Lane wrote: Bruce Momjian writes: Second, the release note item added by this commit: commit d1073c3b4cc Author: Peter Eisentraut Date: Fri Aug 29 10:18:10 2025 +0200 Unfortunately src/tools/add_commit_links.pl can't process the and throws a

Re: PG 18 relnotes and RC1

2025-08-30 Thread Jonathan S. Katz
> On Aug 30, 2025, at 5:56 PM, Bruce Momjian wrote: > > On Sat, Aug 30, 2025 at 03:02:10PM -0500, Nathan Bossart wrote: >>> On Sat, Aug 30, 2025 at 02:42:47PM -0500, Nathan Bossart wrote: >>> On Sat, Aug 30, 2025 at 01:51:23PM -0500, Nathan Bossart wrote: AFAIK nobody has started on the "

Re: PG 18 relnotes and RC1

2025-08-30 Thread Nathan Bossart
On Sat, Aug 30, 2025 at 05:56:12PM -0400, Bruce Momjian wrote: > On Sat, Aug 30, 2025 at 03:02:10PM -0500, Nathan Bossart wrote: >> The 18beta1 announcement [0] has a good list, too. *facepalm* That one >> seems to match mine pretty closely. > > Yes, the list usually comes from the press release

Re: PG 18 relnotes and RC1

2025-08-30 Thread Bruce Momjian
On Sat, Aug 30, 2025 at 06:04:16PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > Actually, in this case, it caught an obvious missing attribution, so it > > actually helped, so let's not change it. > > Fair enough. I'd still like to put in the bit about > > my $major_version = $1; >

Re: PG 18 relnotes and RC1

2025-08-30 Thread Tom Lane
Bruce Momjian writes: > Actually, in this case, it caught an obvious missing attribution, so it > actually helped, so let's not change it. Fair enough. I'd still like to put in the bit about my $major_version = $1; + die "file name $file is not in the expected format\n" +

Re: PG 18 relnotes and RC1

2025-08-30 Thread Bruce Momjian
On Sat, Aug 30, 2025 at 03:02:10PM -0500, Nathan Bossart wrote: > On Sat, Aug 30, 2025 at 02:42:47PM -0500, Nathan Bossart wrote: > > On Sat, Aug 30, 2025 at 01:51:23PM -0500, Nathan Bossart wrote: > >> AFAIK nobody has started on the "new features and enhancements" section. > > > > Quick first at

Re: PG 18 relnotes and RC1

2025-08-30 Thread Bruce Momjian
On Sat, Aug 30, 2025 at 02:17:15PM -0400, Tom Lane wrote: > I wrote: > > If we're okay with items not having credits, then > > add_commit_links.pl's logic for where to put the s needs > > improvement. I don't really understand why it's looking for > > parens in the first place -- why isn't the rul

Re: PG 18 relnotes and RC1

2025-08-30 Thread Bruce Momjian
On Sat, Aug 30, 2025 at 12:52:45PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > Second, the release note item added by this commit: > > commit d1073c3b4cc > > Author: Peter Eisentraut > > Date: Fri Aug 29 10:18:10 2025 +0200 > > > Unfortunately src/tools/add_commit_links.pl c

Re: PG 18 relnotes and RC1

2025-08-30 Thread Nathan Bossart
On Sat, Aug 30, 2025 at 02:42:47PM -0500, Nathan Bossart wrote: > On Sat, Aug 30, 2025 at 01:51:23PM -0500, Nathan Bossart wrote: >> AFAIK nobody has started on the "new features and enhancements" section. > > Quick first attempt: > > * btree skip scan > * async i/o > * oauth > * virtual generate

Re: PG 18 relnotes and RC1

2025-08-30 Thread Nathan Bossart
On Sat, Aug 30, 2025 at 01:51:23PM -0500, Nathan Bossart wrote: > AFAIK nobody has started on the "new features and enhancements" section. Quick first attempt: * btree skip scan * async i/o * oauth * virtual generated columns * OLD/NEW support in RETURNING * pg_upgrade improvements (stats, --jobs

Re: PG 18 relnotes and RC1

2025-08-30 Thread Daniel Gustafsson
> On 30 Aug 2025, at 20:51, Nathan Bossart wrote: > On Sat, Aug 30, 2025 at 12:38:06PM -0400, Bruce Momjian wrote: >> First, the release notes are incomplete because the "new features and >> enhancements" and "Acknowledgments" sections are empty. > > Corey Huinker claims to be working on the lis

Re: PG 18 relnotes and RC1

2025-08-30 Thread Nathan Bossart
On Sat, Aug 30, 2025 at 12:38:06PM -0400, Bruce Momjian wrote: > First, the release notes are incomplete because the "new features and > enhancements" and "Acknowledgments" sections are empty. Corey Huinker claims to be working on the list of acknowledgments [0], but I don't see any patches propos

Re: PG 18 relnotes and RC1

2025-08-30 Thread Tom Lane
I wrote: > If we're okay with items not having credits, then > add_commit_links.pl's logic for where to put the s needs > improvement. I don't really understand why it's looking for > parens in the first place -- why isn't the rule simply "put them > before the first in the item"? I revised the

Re: PG 18 relnotes and RC1

2025-08-30 Thread Tom Lane
Bruce Momjian writes: > Second, the release note item added by this commit: > commit d1073c3b4cc > Author: Peter Eisentraut > Date: Fri Aug 29 10:18:10 2025 +0200 > Unfortunately src/tools/add_commit_links.pl can't process the > and throws an error because the previous line