Em dom., 13 de fev. de 2022 às 23:07, Michael Paquier
escreveu:
> On Thu, Feb 10, 2022 at 11:38:44AM +0900, Michael Paquier wrote:
> > The proposed change is incomplete anyway once you consider this
> > argument. First, there is no need to set up those fields in
> > EndPrepare() anymore if there
At Mon, 14 Feb 2022 11:07:19 +0900, Michael Paquier wrote
in
> On Thu, Feb 10, 2022 at 11:38:44AM +0900, Michael Paquier wrote:
> > The proposed change is incomplete anyway once you consider this
> > argument. First, there is no need to set up those fields in
> > EndPrepare() anymore if there i
On Thu, Feb 10, 2022 at 11:38:44AM +0900, Michael Paquier wrote:
> The proposed change is incomplete anyway once you consider this
> argument. First, there is no need to set up those fields in
> EndPrepare() anymore if there is no origin data, no? It would be good
> to comment that these are fill
On Thu, Feb 10, 2022 at 10:18:15AM +0900, Kyotaro Horiguchi wrote:
> Who repoerted that to you?
Let's bet on Coverity.
> StartPrepare and EndPrepare are virtually a single function that
> accepts some additional operations in the middle. StartPrepare leaves
> the "records" incomplete then EndPre
At Wed, 9 Feb 2022 08:15:45 -0300, Ranier Vilela wrote in
> Hi,
>
> Commit
> https://github.com/postgres/postgres/commit/1eb6d6527aae264b3e0b9c95aa70bb7a594ad1cf,
> modified
> data struct TwoPhaseFileHeader and added two new fields:
>
> XLogRecPtr origin_lsn; /* lsn of this record at origin nod