Re: PostgreSQL shutdown modes

2022-04-04 Thread Robert Haas
On Sat, Apr 2, 2022 at 9:39 AM wrote: > I've waited for April 2nd to submit this comment, but it seemed to me > that the > suggestion about the first-pass checkpoint in 'slow' mode is a > no-foolin' good one. Yeah. While the patch itself is mostly in jest, everything I wrote in the email is unfor

Re: PostgreSQL shutdown modes

2022-04-03 Thread Kyotaro Horiguchi
At Sat, 2 Apr 2022 11:58:55 +0900, Michael Paquier wrote in > On Fri, Apr 01, 2022 at 01:22:05PM -0400, Robert Haas wrote: > > I attach herewith a modest patch to rename these shutdown modes to > > more accurately correspond to their actual characteristics. > > > > Date: Fri, 1 Apr 2022 12:50:05

Re: PostgreSQL shutdown modes

2022-04-02 Thread chap
On 2022-04-01 13:22, Robert Haas wrote: I attach herewith a modest patch to rename these shutdown modes to more accurately correspond to their actual characteristics. I've waited for April 2nd to submit this comment, but it seemed to me that the suggestion about the first-pass checkpoint in 's

Re: PostgreSQL shutdown modes

2022-04-01 Thread Rushabh Lathia
+1 for the idea of changing the name, as it's really confusing. I had quick check in the patch and noticed below replacements: -#define SmartShutdown 1 -#define FastShutdown 2 -#define ImmediateShutdown 3 +#define DumbShutdown 1 +#define SlowShutdown 2 +#define CrappyShutdown 3 About the new nam

Re: PostgreSQL shutdown modes

2022-04-01 Thread Michael Paquier
On Fri, Apr 01, 2022 at 01:22:05PM -0400, Robert Haas wrote: > I attach herewith a modest patch to rename these shutdown modes to > more accurately correspond to their actual characteristics. > > Date: Fri, 1 Apr 2022 12:50:05 -0400 I love the idea. Just in time, before the feature freeze deadlin

Re: PostgreSQL shutdown modes

2022-04-01 Thread Justin Pryzby
Isn't this missing support in pg_dumb ?