Re: Potential problem in commit f777d773878 and 4f7f7b03758

2025-09-08 Thread Dilip Kumar
On Mon, Sep 8, 2025 at 10:36 PM Álvaro Herrera wrote: > > On 2025-Sep-04, Dilip Kumar wrote: > > > What's the complain, Srinath complained that if you try to LOAD > > '$libdir/foo' explicitly then it should load this from $libdir path > > and it will indeed do so because it will directly call > >

Re: Potential problem in commit f777d773878 and 4f7f7b03758

2025-09-08 Thread Álvaro Herrera
On 2025-Sep-04, Dilip Kumar wrote: > What's the complain, Srinath complained that if you try to LOAD > '$libdir/foo' explicitly then it should load this from $libdir path > and it will indeed do so because it will directly call > expand_dynamic_library_name() and in this function if there is '/' i

Re: Potential problem in commit f777d773878 and 4f7f7b03758

2025-09-04 Thread Álvaro Herrera
On 2025-Aug-27, Peter Eisentraut wrote: > > > > On Sun, Aug 24, 2025 at 5:59 PM Srinath Reddy Sadipiralla > > > > wrote: > > > > > > > > > > Thanks Dilip and Matheus for working on this , i reviewed the > > > > > latest patch given [by] Matheus and it LGTM but i have doubt > > > > > that in f777

Re: Potential problem in commit f777d773878 and 4f7f7b03758

2025-09-04 Thread Dilip Kumar
On Thu, Sep 4, 2025 at 5:13 PM Álvaro Herrera wrote: > > On 2025-Aug-27, Peter Eisentraut wrote: > > > > > > On Sun, Aug 24, 2025 at 5:59 PM Srinath Reddy Sadipiralla > > > > > wrote: > > > > > > > > > > > > Thanks Dilip and Matheus for working on this , i reviewed the > > > > > > latest patch gi

Re: Potential problem in commit f777d773878 and 4f7f7b03758

2025-08-27 Thread Dilip Kumar
On Wed, Aug 27, 2025 at 7:47 PM Peter Eisentraut wrote: > > >> Please find the revised patch with improved comments and commit messages. > >> > > Thanks for the improvements! LGTM. > > committed, thanks > Thanks Peter. -- Regards, Dilip Kumar Google

Re: Potential problem in commit f777d773878 and 4f7f7b03758

2025-08-27 Thread Peter Eisentraut
On 27.08.25 14:39, Matheus Alcantara wrote: On Tue Aug 26, 2025 at 3:26 AM -03, Dilip Kumar wrote: On Tue, Aug 26, 2025 at 11:31 AM Dilip Kumar wrote: On Sun, Aug 24, 2025 at 5:59 PM Srinath Reddy Sadipiralla wrote: Hi, Thanks Dilip and Matheus for working on this , i reviewed the latest p

Re: Potential problem in commit f777d773878 and 4f7f7b03758

2025-08-27 Thread Matheus Alcantara
On Tue Aug 26, 2025 at 3:26 AM -03, Dilip Kumar wrote: > On Tue, Aug 26, 2025 at 11:31 AM Dilip Kumar wrote: >> >> On Sun, Aug 24, 2025 at 5:59 PM Srinath Reddy Sadipiralla >> wrote: >> > >> > Hi, >> > Thanks Dilip and Matheus for working on this , i reviewed the >> > latest patch given my Matheu

Re: Potential problem in commit f777d773878 and 4f7f7b03758

2025-08-25 Thread Dilip Kumar
On Tue, Aug 26, 2025 at 11:31 AM Dilip Kumar wrote: > > On Sun, Aug 24, 2025 at 5:59 PM Srinath Reddy Sadipiralla > wrote: > > > > Hi, > > Thanks Dilip and Matheus for working on this , i reviewed the latest patch > > given my Matheus and it LGTM but i have doubt that in f777d773878 commit > >

Re: Potential problem in commit f777d773878 and 4f7f7b03758

2025-08-25 Thread Dilip Kumar
On Sun, Aug 24, 2025 at 5:59 PM Srinath Reddy Sadipiralla wrote: > > Hi, > Thanks Dilip and Matheus for working on this , i reviewed the latest patch > given my Matheus and it LGTM but i have doubt that in f777d773878 commit the > $libdir was moved out from expand_dynamic_library_name into > lo

Re: Potential problem in commit f777d773878 and 4f7f7b03758

2025-08-24 Thread Srinath Reddy Sadipiralla
On Sun, Aug 24, 2025 at 5:58 PM Srinath Reddy Sadipiralla < srinath2...@gmail.com> wrote: > Hi, > Thanks Dilip and Matheus for working on this , i reviewed the latest patch > given my Matheus and it LGTM but i have doubt that in f777d773878 commit > the $libdir was moved out from expand_dynamic_li

Re: Potential problem in commit f777d773878 and 4f7f7b03758

2025-08-24 Thread Srinath Reddy Sadipiralla
Hi, Thanks Dilip and Matheus for working on this , i reviewed the latest patch given my Matheus and it LGTM but i have doubt that in f777d773878 commit the $libdir was moved out from expand_dynamic_library_name into load_external_function because if someone specifies LOAD '$libdir/foo' explicitly t

Re: Potential problem in commit f777d773878 and 4f7f7b03758

2025-08-23 Thread Dilip Kumar
On Fri, Aug 22, 2025 at 7:04 PM Matheus Alcantara wrote: > > Hi, > > Thanks for reporting this! > > On Fri Aug 22, 2025 at 7:34 AM -03, Dilip Kumar wrote: > > Simple test to reproduce: > > > > Change the module path for any extension as below, like I have done > > for amcheck and then copy the .so

Re: Potential problem in commit f777d773878 and 4f7f7b03758

2025-08-22 Thread Matheus Alcantara
Hi, Thanks for reporting this! On Fri Aug 22, 2025 at 7:34 AM -03, Dilip Kumar wrote: > Simple test to reproduce: > > Change the module path for any extension as below, like I have done > for amcheck and then copy the .so file at $libdir/test/ folder. > module_pathname = '$libdir/test/amcheck' >

Re: Potential problem in commit f777d773878 and 4f7f7b03758

2025-08-22 Thread Dilip Kumar
On Fri, Aug 22, 2025 at 4:04 PM Dilip Kumar wrote: > > Simple test to reproduce: > > Change the module path for any extension as below, like I have done > for amcheck and then copy the .so file at $libdir/test/ folder. > module_pathname = '$libdir/test/amcheck' > > While creating the extension it