Re: Re: [HACKERS] Custom compression methods

On Mon, Aug 31, 2020 at 10:45 AM Amit Khandekar wrote: > > On Thu, 13 Aug 2020 at 17:18, Dilip Kumar wrote: > > I have rebased the patch on the latest head and currently, broken into 3 > > parts. > > > > v1-0001: As suggested by Robert, it provides the syntax support for > > setting the compress

Re: Re: [HACKERS] Custom compression methods

On Thu, 13 Aug 2020 at 17:18, Dilip Kumar wrote: > I have rebased the patch on the latest head and currently, broken into 3 > parts. > > v1-0001: As suggested by Robert, it provides the syntax support for > setting the compression method for a column while creating a table and > adding columns.

Re: Re: [HACKERS] Custom compression methods

On Mon, Aug 24, 2020 at 2:12 AM Dilip Kumar wrote: > IIUC, the main reason for using this flag is for taking the decision > whether we need any detoasting for this tuple. For example, if we are > rewriting the table because the compression method is changed then if > HEAP_HASCUSTOMCOMPRESSED bit

Re: Re: [HACKERS] Custom compression methods

On Thu, Aug 13, 2020 at 5:18 PM Dilip Kumar wrote: > There was some question which Robert has asked in this mail, please find my answer inline. Also, I have a few questions regarding further splitting up this patch. > On Fri, Jun 19, 2020 at 10:33 PM Robert Haas wrote: > > > > > > - One thing

Re: Re: [HACKERS] Custom compression methods

On Thu, Mar 7, 2019 at 2:51 AM Alexander Korotkov wrote: > Yes. I took a look at code of this patch. I think it's in pretty good > shape. But high level review/discussion is required. I agree that the code of this patch is in pretty good shape, although there is a lot of rebasing needed at th

Re: Re: Re: [HACKERS] Custom compression methods

On Fri, Mar 15, 2019 at 6:07 PM David Steele wrote: > On 3/7/19 11:50 AM, Alexander Korotkov wrote: > > On Thu, Mar 7, 2019 at 10:43 AM David Steele > > wrote: > > > > On 2/28/19 5:44 PM, Ildus Kurbangaliev wrote: > > > > > there are another set of patches. >

Re: Re: Re: [HACKERS] Custom compression methods

On 3/7/19 11:50 AM, Alexander Korotkov wrote: On Thu, Mar 7, 2019 at 10:43 AM David Steele > wrote: On 2/28/19 5:44 PM, Ildus Kurbangaliev wrote: > there are another set of patches. > Only rebased to current master. > > Also I will change stat

Re: Re: [HACKERS] Custom compression methods

On Thu, Mar 7, 2019 at 10:43 AM David Steele wrote: > On 2/28/19 5:44 PM, Ildus Kurbangaliev wrote: > > > there are another set of patches. > > Only rebased to current master. > > > > Also I will change status on commitfest to 'Needs review'. > > This patch has seen periodic rebases but no code r

Re: Re: [HACKERS] Custom compression methods

On 2/28/19 5:44 PM, Ildus Kurbangaliev wrote: there are another set of patches. Only rebased to current master. Also I will change status on commitfest to 'Needs review'. This patch has seen periodic rebases but no code review that I can see since last January 2018. As Andres noted in [1],