Re: Trivial fix for comment of function table_tuple_lock

On Mon, Sep 22, 2025 at 11:41 PM Fujii Masao wrote: > > I noticed a few other issues. Wouldn’t it be better to fix these together? > > * changingPart is listed as an output parameter for table_tuple_delete(), > but it looks like an input. > Fixed. changingPart is of type bool, it cannot pass

Re: Trivial fix for comment of function table_tuple_lock

Hi Fujii-san, > On Sep 24, 2025, at 23:57, Fujii Masao wrote: > > Got it. I've pushed the patch and used that email address in the commit log. > Thanks! Thanks a lot for helping. Would you mind take a look at the other one-line fix of a function comment: https://www.postgresql.org/message-id

Re: Trivial fix for comment of function table_tuple_lock

On Tue, Sep 23, 2025 at 9:51 AM Chao Li wrote: > > > > On Sep 23, 2025, at 08:45, Fujii Masao wrote: > > > I noticed the commit message in the patch lists you as "Author: Chao > Li ", > but in this discussion you've been using "[email protected]", > which also seems to be the address used in

Re: Trivial fix for comment of function table_tuple_lock

> On Sep 23, 2025, at 08:45, Fujii Masao wrote: > > > I noticed the commit message in the patch lists you as "Author: Chao > Li mailto:[email protected]>>", > but in this discussion you've been using "[email protected] > ", > which also seems to be the addres

Re: Trivial fix for comment of function table_tuple_lock

On Tue, Sep 23, 2025 at 7:44 AM Chao Li wrote: > > > On Mon, Sep 22, 2025 at 11:41 PM Fujii Masao wrote: >> >> >> I noticed a few other issues. Wouldn’t it be better to fix these together? >> >> * changingPart is listed as an output parameter for table_tuple_delete(), >> but it looks like an

Re: Trivial fix for comment of function table_tuple_lock

On Mon, Sep 22, 2025 at 2:54 PM Chao Li wrote: > > Hi Fujii-san, > > Thank you very much for taking care of this patch. > > I just updated the patch, see attached v2. In v2, I removed "tid" from the > comment of heap_lock_tuple(), and I found a couple of more occurrences of > "relation"=>"rel" i

Re: Trivial fix for comment of function table_tuple_lock

On Thu, Sep 11, 2025 at 2:40 PM Chao Li wrote: > > Hi Hackers, > > Just fixed an one-word error in comment. Please take a look. Thanks for the patch! LGTM. It looks like this happened because heapam_tuple_lock() and heap_lock_tuple() use the argument relation instead of rel, and the comments for

Re: Trivial fix for comment of function table_tuple_lock

Hi Fujii-san, Thank you very much for taking care of this patch. I just updated the patch, see attached v2. In v2, I removed "tid" from the comment of heap_lock_tuple(), and I found a couple of more occurrences of "relation"=>"rel" in tableam.h. Best regards, Chao Li (Evan) -