When analyzing a partitioned table, I think you should use ANALYZE ONLY,
or otherwise avoid processing the children twice.
Thanks for handling this. I was recently suprised to learn that
vacuumdb doesn't process parents.
--
Justin
On Wed, 2025-08-20 at 13:31 +0900, Fujii Masao wrote:
> OK, so for now I've pushed the patch to master. Thanks!
Thank you for working on that!
Yours,
Laurenz Albe
On Wed, Aug 20, 2025 at 12:16 AM Laurenz Albe wrote:
>
> On Tue, 2025-08-19 at 23:40 +0900, Fujii Masao wrote:
> > > > --- a/doc/src/sgml/ref/vacuumdb.sgml
> > > > +++ b/doc/src/sgml/ref/vacuumdb.sgml
> > > > @@ -397,6 +397,15 @@ PostgreSQL documentation
> > > > Multiple tables can be va
On Tue, 2025-08-19 at 23:40 +0900, Fujii Masao wrote:
> > > --- a/doc/src/sgml/ref/vacuumdb.sgml
> > > +++ b/doc/src/sgml/ref/vacuumdb.sgml
> > > @@ -397,6 +397,15 @@ PostgreSQL documentation
> > > Multiple tables can be vacuumed by writing multiple
> > > -t switches.
> > >
On Mon, Aug 18, 2025 at 3:40 PM Laurenz Albe wrote:
>
> On Mon, 2025-08-18 at 11:38 +0900, Fujii Masao wrote:
> > Thanks! So I've updated the patch based on my earlier comments.
> > Unless there are objections, I'll commit the attached version to master
> > only.
>
> I am fine with your patch.
T
On Mon, 2025-08-18 at 11:38 +0900, Fujii Masao wrote:
> Thanks! So I've updated the patch based on my earlier comments.
> Unless there are objections, I'll commit the attached version to master only.
I am fine with your patch.
One suggestion:
> --- a/doc/src/sgml/ref/vacuumdb.sgml
> +++ b/doc/sr
On Thu, Aug 7, 2025 at 5:52 AM Laurenz Albe wrote:
> > I understand your point. But on second thought, since the patch changes
> > behavior, I'm leaning toward treating it as an improvement, so it should
> > only go to master...
>
> I agree that this behavior change should not be backpatched.
> Th
On Thu, Aug 7, 2025 at 3:14 AM Nathan Bossart wrote:
> I also am leaning towards treating this as v19 material. It's a nontrivial
> behavior change, and this option is useful for major version upgrades,
> which is an area that we really don't want to surprise users too much.
+1
> Furthermore, a
On Wed, 2025-08-06 at 23:25 +0900, Fujii Masao wrote:
> On Wed, Aug 6, 2025 at 1:01 PM Mircea Cadariu
> wrote:
> > Overall, I like the change. But I have one question: should this be treated
> > as
> > a bug fix that we back-patch to supported branches, or is it more of
> > an improvement that s
On Wed, Aug 06, 2025 at 11:25:53PM +0900, Fujii Masao wrote:
> On Wed, Aug 6, 2025 at 1:01 PM Mircea Cadariu
> wrote:
>> Overall, I like the change. But I have one question: should this be treated
>> as
>> a bug fix that we back-patch to supported branches, or is it more of
>> an improvement tha
On Wed, Aug 6, 2025 at 1:01 PM Mircea Cadariu wrote:
> Overall, I like the change. But I have one question: should this be treated as
> a bug fix that we back-patch to supported branches, or is it more of
> an improvement that should only go into master?
>
> I reckon it might make sense to back-pa
Hi,
On 30/07/2025 12:49, Fujii Masao wrote:
I've started reviewing the patch since it's marked as ready for committer.
Thanks!
Overall, I like the change. But I have one question: should this be treated as
a bug fix that we back-patch to supported branches, or is it more of
an improvement that
On Fri, Jul 11, 2025 at 7:42 PM Mircea Cadariu wrote:
>
> On 11/07/2025 10:51, Laurenz Albe wrote:
>
> > Good idea; done in the attached version 2 of the patch.
>
> Thanks! Looks good. I have set the status of the Commitfest entry to
> "Ready for Committer".
I've started reviewing the patch since
On 11/07/2025 10:51, Laurenz Albe wrote:
Good idea; done in the attached version 2 of the patch.
Thanks! Looks good. I have set the status of the Commitfest entry to
"Ready for Committer".
Kind regards,
Mircea Cadariu
[moving to pgsql-hackers]
On Thu, 2025-07-10 at 17:20 +0100, Mircea Cadariu wrote:
> I have only one suggestion for the patch. Consider adding a
> corresponding test in src/bin/scripts/t/100_vacuumdb.pl.
>
> Proposal (I used this to check the patch):
>
> $node->safe_psql('postgres',
>
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:tested, passed
Hi Laurenz,
Nice focused patch.
Applied successfully on co
16 matches
Mail list logo
