Re: duplicate logging in pg_createsubscriber

2025-10-18 Thread Chao Li
> On Oct 8, 2025, at 14:29, Peter Smith wrote: > > Perhaps that 2nd log was once supposed to say "created" (past tense), > but even that seemed redundant. > > Here is a small patch to remove the log duplication by keeping only > the log *within* the function. > > Thoughts? > > == > Kind

Re: duplicate logging in pg_createsubscriber

2025-10-17 Thread Michael Paquier
On Thu, Oct 09, 2025 at 01:36:36PM +1100, Peter Smith wrote: > Thanks. Done this one. -- Michael signature.asc Description: PGP signature

Re: duplicate logging in pg_createsubscriber

2025-10-17 Thread Peter Smith
On Thu, Oct 9, 2025 at 1:31 PM Chao Li wrote: > > > > On Oct 8, 2025, at 14:29, Peter Smith wrote: > > Perhaps that 2nd log was once supposed to say "created" (past tense), > but even that seemed redundant. > > Here is a small patch to remove the log duplication by keeping only > the log *within*

Re: duplicate logging in pg_createsubscriber

2025-10-08 Thread Peter Smith
On Thu, Oct 9, 2025 at 4:03 PM Michael Paquier wrote: > > On Thu, Oct 09, 2025 at 01:36:36PM +1100, Peter Smith wrote: > > Thanks. > > Done this one. > -- Thanks for pushing! == Kind Regards, Peter Smith. Fujitsu Australia

Re: duplicate logging in pg_createsubscriber

2025-10-08 Thread Michael Paquier
On Wed, Oct 08, 2025 at 05:29:20PM +1100, Peter Smith wrote: > It didn't look right to me. > > I found the code is doing: > - pg_log_info("creating the replication slot unconditional inside > create_logical_replication_slot > - pg_log_info("create replication slot...") immediately after call to >