Re: old_snapshot: add test for coverage

2022-12-06 Thread Dong Wook Lee
On Mon, Aug 8, 2022 at 2:37 PM Tom Lane wrote: > > Dong Wook Lee writes: > > I wrote a test of the old_snapshot extension for coverage. > > Hmm, does this really provide any meaningful coverage? The test > sure looks like it's not doing much. Previously written tests were simply test codes to i

Re: old_snapshot: add test for coverage

2022-11-17 Thread Daniel Gustafsson
> On 8 Aug 2022, at 07:37, Tom Lane wrote: > Dong Wook Lee writes: >> I wrote a test of the old_snapshot extension for coverage. > > Hmm, does this really provide any meaningful coverage? The test > sure looks like it's not doing much. Looking at this I agree, this test doesn't provide enough

Re: old_snapshot: add test for coverage

2022-08-07 Thread Tom Lane
Dong Wook Lee writes: > I wrote a test of the old_snapshot extension for coverage. Hmm, does this really provide any meaningful coverage? The test sure looks like it's not doing much. I spent some time a week or so ago trying to graft testing of contrib/old_snapshot into src/test/modules/snapsh