On 11/29/17 13:49, Andres Freund wrote:
On 2017-11-27 22:53:41 -0500, Tom Lane wrote:
Tomas Vondra writes:
I'm a bit puzzled by this code in SH_COMPUTE_PARAMETERS:
if (tb->size == SH_MAX_SIZE)
tb->sizemask = 0;
else
tb->sizemask = tb->size - 1;
Doesn't that me
On 2017-11-27 22:53:41 -0500, Tom Lane wrote:
> Tomas Vondra writes:
> > I'm a bit puzzled by this code in SH_COMPUTE_PARAMETERS:
>
> > if (tb->size == SH_MAX_SIZE)
> > tb->sizemask = 0;
> > else
> > tb->sizemask = tb->size - 1;
>
> > Doesn't that mean that with SH_MAX_SI
Tomas Vondra writes:
> I'm a bit puzzled by this code in SH_COMPUTE_PARAMETERS:
> if (tb->size == SH_MAX_SIZE)
> tb->sizemask = 0;
> else
> tb->sizemask = tb->size - 1;
> Doesn't that mean that with SH_MAX_SIZE we end up with sizemask being 0
> (i.e. no bits set)?
Yeah,
