On Tue, Jul 22, 2025 at 11:17:42AM +0900, Michael Paquier wrote:
> On Mon, Jul 21, 2025 at 09:06:59PM -0500, Nathan Bossart wrote:
>> On Tue, Jul 22, 2025 at 10:37:05AM +0900, Michael Paquier wrote:
>>> This would not choke as long as the old cluster is at least at v10,
>>> but well why not.
>>
>>
On Mon, Jul 21, 2025 at 09:06:59PM -0500, Nathan Bossart wrote:
> On Tue, Jul 22, 2025 at 10:37:05AM +0900, Michael Paquier wrote:
>> This would not choke as long as the old cluster is at least at v10,
>> but well why not.
>
> I'm not sure what you mean. allow_in_place_tablespaces was added in v1
On Tue, Jul 22, 2025 at 10:37:05AM +0900, Michael Paquier wrote:
> On Mon, Jul 21, 2025 at 07:57:32PM -0500, Nathan Bossart wrote:
> +if (!defined($ENV{oldinstall}))
> +{
> +$new->append_conf('postgresql.conf',
> +"allow_in_place_tablespaces = true");
> +$old->ap
On Mon, Jul 21, 2025 at 07:57:32PM -0500, Nathan Bossart wrote:
+if (!defined($ENV{oldinstall}))
+{
+$new->append_conf('postgresql.conf',
+"allow_in_place_tablespaces = true");
+$old->append_conf('postgresql.conf',
+"allow_in_place_tablespaces = true"
On Mon, Jul 21, 2025 at 08:16:12PM -0400, Corey Huinker wrote:
> Everything here makes sense to me, but I do have one question:
Thanks for reviewing.
> In src/bin/pg_upgrade/info.c
> @@ -616,11 +630,21 @@ process_rel_infos(DbInfo *dbinfo, PGresult *res, void
> *arg)
> + if (inplace)
> + tablespac
On Tue, Jul 1, 2025 at 4:06 PM Nathan Bossart
wrote:
> rebased
>
> --
> nathan
Everything here makes sense to me, but I do have one question:
In src/bin/pg_upgrade/info.c
@@ -616,11 +630,21 @@ process_rel_infos(DbInfo *dbinfo, PGresult *res, void
*arg)
+ if (inplace)
+ tablespace = psprintf("%
rebased
--
nathan
>From 90985d810f3bed653d3d73553e6236d1f7fb7154 Mon Sep 17 00:00:00 2001
From: Nathan Bossart
Date: Mon, 28 Apr 2025 14:52:11 -0500
Subject: [PATCH v3 1/1] Teach pg_upgrade to handle in-place tablespaces.
Presently, pg_upgrade assumes that all non-default tablespaces
don't move
On Mon, Apr 28, 2025 at 04:07:16PM -0500, Nathan Bossart wrote:
> On Tue, Mar 25, 2025 at 04:03:57PM -0500, Nathan Bossart wrote:
>> I also wanted to draw attention to this note in 0003:
>>
>> /*
>> * XXX: The below line is a hack to deal with the fact that we
>>
