Re[2]: Alter index rename concurrently to

2018-10-08 Thread Andrey Klychkov
> Attached is an updated patch. That's OK now, the patch applying is without any errors. I have no more remarks. >Пятница, 5 октября 2018, 13:04 +03:00 от Peter Eisentraut >: > >On 03/10/2018 13:51, Andrey Klychkov wrote: >> 1. Patch was applied without any errors except a part related to >> d

Re[2]: Alter index rename concurrently to

2018-10-03 Thread Andrey Klychkov
> Based on these assertions, here is my proposed patch. It lowers the > lock level for index renaming to ShareUpdateExclusiveLock. Hi, Peter I made small review for your patch: Server source code got from https://github.com/postgres/postgres.git 1. Patch was applied without any errors except a p

Fwd: Re[2]: Alter index rename concurrently to

2018-07-25 Thread Andrey Klychkov
Понедельник, 23 июля 2018, 18:06 +03:00 от Peter Eisentraut < peter.eisentr...@2ndquadrant.com >: > >You appear to be saying that you think that renaming an index >concurrently is not safe No, I didn't say it about renaming indexes. I tried to say that it does not make sense exactly to rename a ta

Re[2]: Alter index rename concurrently to

2018-07-23 Thread Andrey Klychkov
>Среда, 18 июля 2018, 12:21 +03:00 от Peter Eisentraut >: > > >In your patch, the effect of the CONCURRENTLY keyword is just to change >the lock level, without any further changes. That doesn't make much >sense. If we think the lower lock level is OK, then we should just use >it always. I was

Re[2]: Alter index rename concurrently to

2018-07-18 Thread Andrey Klychkov
>Среда, 18 июля 2018, 12:21 +03:00 от Peter Eisentraut >: > >If we think the lower lock level is OK, then we should just use >it always. > Hi, I absolutely agree with you. If lower locking is safe and possible to be used by default in renaming it will be great. What stage is solving of this issu

Re[2]: Alter index rename concurrently to

2018-07-17 Thread Andrey Klychkov
> Понедельник, 16 июля 2018, 22:19 +03:00 от Andrey Borodin > : > >Hi! > >> 16 июля 2018 г., в 22:58, Andrey Klychkov < aaklych...@mail.ru > написал(а): >> Dear hackers! >> >> I have an idea to facilitate work with index rebuilding. >> >> "ALTER INDEX ... RENAME CONCURRENTLY TO ..." > >The i

Re[2]: Alter index rename concurrently to

2018-07-17 Thread Andrey Klychkov
>Понедельник, 16 июля 2018, 22:40 +03:00 от Victor Yegorov : > >пн, 16 июл. 2018 г. в 21:58, Andrey Klychkov < aaklych...@mail.ru >: >>I made a patch to solve this issue (see the attachment). >>It allows to avoid locks by a query like this: >>“alter index rename CONCURRENTLY to ”. > >Please, ha