On 16.01.23 23:43, Nathan Bossart wrote:
On Mon, Jan 16, 2023 at 12:01:47PM +0100, Peter Eisentraut wrote:
I have updated the patch as you suggested and split out the aggregate issue
into a separate patch for clarity.
LGTM
committed
On Mon, Jan 16, 2023 at 12:01:47PM +0100, Peter Eisentraut wrote:
> I have updated the patch as you suggested and split out the aggregate issue
> into a separate patch for clarity.
LGTM
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
ter Eisentraut
Date: Mon, 16 Jan 2023 11:49:24 +0100
Subject: [PATCH v2 2/2] Refactor recordExtObjInitPriv()
Instead of half a dozen of mostly-duplicate conditional branches,
write one common one that can handle most catalogs. We already have
all the information we need, such as which system cat
On Thu, Jan 12, 2023 at 12:20:50PM -0500, Tom Lane wrote:
> Peter Eisentraut writes:
>> On 12.01.23 01:04, Nathan Bossart wrote:
>> - classoid == AggregateRelationId ||
>>> I noticed that AggregateRelationId isn't listed in the ObjectProperty
>>> array, so I think recordExtObjI
Peter Eisentraut writes:
> On 12.01.23 01:04, Nathan Bossart wrote:
> - classoid == AggregateRelationId ||
>> I noticed that AggregateRelationId isn't listed in the ObjectProperty
>> array, so I think recordExtObjInitPriv() will begin erroring for that
>> classoid instead of i
On 12.01.23 01:04, Nathan Bossart wrote:
-classoid == AggregateRelationId ||
I noticed that AggregateRelationId isn't listed in the ObjectProperty
array, so I think recordExtObjInitPriv() will begin erroring for that
classoid instead of ignoring it like we do today.
Hmm
On Tue, Dec 27, 2022 at 09:56:10AM +0100, Peter Eisentraut wrote:
> Refactor recordExtObjInitPriv(): Instead of half a dozen of
> mostly-duplicate conditional branches, write one common one that can handle
> most catalogs. We already have all the information we need, such as which
Another aclchk.c refactoring patch, similar to [0] and [1].
Refactor recordExtObjInitPriv(): Instead of half a dozen of
mostly-duplicate conditional branches, write one common one that can
handle most catalogs. We already have all the information we need, such
as which system catalog
