Re: Refactoring code stripping trailing \n and \r from strings

2019-08-08 Thread Michael Paquier
On Wed, Aug 07, 2019 at 10:10:36AM +0900, Michael Paquier wrote: > Thanks for the review, Bruce! Tom, do you have any objections? hearing nothing but cicadas from outside, applied. There were some warnings I missed with the first version, which are fixed. -- Michael signature.asc Description:

Re: Refactoring code stripping trailing \n and \r from strings

2019-08-06 Thread Michael Paquier
On Tue, Aug 06, 2019 at 03:10:33PM -0400, Bruce Momjian wrote: > On Thu, Aug 1, 2019 at 12:18:20PM +0900, Michael Paquier wrote: >> b654714 has reworked the way we handle removal of CLRF for several >> code paths, and has repeated the same code patterns to do that in 8 >> different places. Could

Re: Refactoring code stripping trailing \n and \r from strings

2019-08-06 Thread Bruce Momjian
On Thu, Aug 1, 2019 at 12:18:20PM +0900, Michael Paquier wrote: > Hi Tom, > > b654714 has reworked the way we handle removal of CLRF for several > code paths, and has repeated the same code patterns to do that in 8 > different places. Could it make sense to refactor things as per the > attached

Refactoring code stripping trailing \n and \r from strings

2019-07-31 Thread Michael Paquier
Hi Tom, b654714 has reworked the way we handle removal of CLRF for several code paths, and has repeated the same code patterns to do that in 8 different places. Could it make sense to refactor things as per the attached with a new routine in common/string.c? Thanks, -- Michael diff --git a/src/b