Re: Refactoring of connection with password prompt loop for frontends

2019-09-27 Thread Michael Paquier
On Thu, Sep 26, 2019 at 10:06:27AM -0300, Alvaro Herrera wrote: > Hmm, you have an XXX comment that appears to need addressing; and I'd > add an explanation about the looping behavior to the comment atop the > new function. > > I see that vacuumlo and scripts/common retain their "have_password" >

Re: Refactoring of connection with password prompt loop for frontends

2019-09-26 Thread Alvaro Herrera
On 2019-Sep-26, Michael Paquier wrote: > On Wed, Sep 25, 2019 at 05:47:39PM -0300, Alvaro Herrera wrote: > > This patch has been absolutely overlooked by reviewers. Euler, you're > > registered as a reviewer for it. Will you submit a review soon? :-) > > > > It does not currently apply, so if

Re: Refactoring of connection with password prompt loop for frontends

2019-09-26 Thread Michael Paquier
On Wed, Sep 25, 2019 at 05:47:39PM -0300, Alvaro Herrera wrote: > This patch has been absolutely overlooked by reviewers. Euler, you're > registered as a reviewer for it. Will you submit a review soon? :-) > > It does not currently apply, so if we get a rebase, that'd be good too. Here you go.

Re: Refactoring of connection with password prompt loop for frontends

2019-09-25 Thread Alvaro Herrera
This patch has been absolutely overlooked by reviewers. Euler, you're registered as a reviewer for it. Will you submit a review soon? :-) It does not currently apply, so if we get a rebase, that'd be good too. -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Developmen

Refactoring of connection with password prompt loop for frontends

2019-08-22 Thread Michael Paquier
Hi all, In six places of the code tree (+ one in psql which is a bit different), we have the following pattern for frontend tools to connect to a backend with a password prompt, roughly like that: do { [...] conn = PQconnectdbParams(keywords, values, true); [...] if (PQstatus(con