Re: Remove unnecessary commas for goto labels

2022-10-10 Thread Japin Li
On Mon, 10 Oct 2022 at 16:18, John Naylor wrote: > Interestingly, I did find that in C, some statement is needed after a > label, even an empty one, otherwise it won't compile. Yeah, this is required by ISO C [1]. > That's not the case here, though, so pushed. Thank you! [1]

Re: Remove unnecessary commas for goto labels

2022-10-10 Thread John Naylor
On Sun, Oct 9, 2022 at 10:08 AM Julien Rouhaud wrote: > > Hi, > > On Sun, Oct 09, 2022 at 07:42:58AM +0800, Japin Li wrote: > > > > Hi hackers, > > > > I find there are some unnecessary commas for goto lables, > > attached a patch to remove them. > > You mean semi-colon? +1, and a quick regex

Re: Remove unnecessary commas for goto labels

2022-10-08 Thread Japin Li
On Sun, 09 Oct 2022 at 11:07, Julien Rouhaud wrote: > Hi, > > On Sun, Oct 09, 2022 at 07:42:58AM +0800, Japin Li wrote: >> >> Hi hackers, >> >> I find there are some unnecessary commas for goto lables, >> attached a patch to remove them. > > You mean semi-colon? +1, and a quick regex later I

Re: Remove unnecessary commas for goto labels

2022-10-08 Thread Julien Rouhaud
Hi, On Sun, Oct 09, 2022 at 07:42:58AM +0800, Japin Li wrote: > > Hi hackers, > > I find there are some unnecessary commas for goto lables, > attached a patch to remove them. You mean semi-colon? +1, and a quick regex later I don't see any other occurrence.

Remove unnecessary commas for goto labels

2022-10-08 Thread Japin Li
:43 +0800 Subject: [PATCH v1 1/1] Remove unnecessary commas for goto labels --- src/backend/access/transam/slru.c | 2 +- src/backend/executor/nodeModifyTable.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/access/transam/slru.c b/src/backend/access/tran