Re: Remove unused variable from SharedSort

2020-11-15 Thread Michael Paquier
On Sun, Nov 15, 2020 at 03:49:58PM +0530, Dilip Kumar wrote: > On Sun, Nov 15, 2020 at 12:50 PM Bharath Rupireddy > wrote: >> We could have used that variable for an assert like >> Assert(state->worker <= shared->nTapes) in worker_freeze_result_tape() >> before accessing shared->tapes[state->work

Re: Remove unused variable from SharedSort

2020-11-15 Thread Dilip Kumar
On Sun, Nov 15, 2020 at 12:50 PM Bharath Rupireddy wrote: > > On Thu, Nov 12, 2020 at 5:29 PM Dilip Kumar wrote: > > > > While going through the code I noticed that the nTapes member in > > SharedSort is unused. This is just initialized with nworkers but > > never used. The attached patch remov

Re: Remove unused variable from SharedSort

2020-11-14 Thread Bharath Rupireddy
On Thu, Nov 12, 2020 at 5:29 PM Dilip Kumar wrote: > > While going through the code I noticed that the nTapes member in > SharedSort is unused. This is just initialized with nworkers but > never used. The attached patch removes this variable. > We could have used that variable for an assert lik

Remove unused variable from SharedSort

2020-11-12 Thread Dilip Kumar
While going through the code I noticed that the nTapes member in SharedSort is unused. This is just initialized with nworkers but never used. The attached patch removes this variable. -- Regards, Dilip Kumar EnterpriseDB: http://www.enterprisedb.com v1-0001-Remove-unused-structure-member-from