Re: Removing shm_mq.c's volatile qualifiers

2018-03-01 Thread Andres Freund
Hi, On 2018-02-12 12:52:32 +1300, Thomas Munro wrote: > From e584628bb846be11a137b5216e955284dfd646a5 Mon Sep 17 00:00:00 2001 > From: Thomas Munro > Date: Thu, 8 Feb 2018 18:50:32 +1300 > Subject: [PATCH] Remove volatile qualifiers from shm_mq.c. > > Since commit 0709b7ee, spinlock primitives i

Re: Removing shm_mq.c's volatile qualifiers

2018-02-12 Thread Thomas Munro
On Tue, Feb 13, 2018 at 9:09 AM, Robert Haas wrote: > On Sun, Feb 11, 2018 at 6:52 PM, Thomas Munro > wrote: >> As far as I can see, all the volatile qualifiers in shm_mq.c have been >> redundant since ec9037df263. > > That's the commit that added shm_mq.c. ITYM 0709b7ee as you said in > the com

Re: Removing shm_mq.c's volatile qualifiers

2018-02-12 Thread Robert Haas
On Sun, Feb 11, 2018 at 6:52 PM, Thomas Munro wrote: > As far as I can see, all the volatile qualifiers in shm_mq.c have been > redundant since ec9037df263. That's the commit that added shm_mq.c. ITYM 0709b7ee as you said in the commit message -- Robert Haas EnterpriseDB: http://www.enterp

Removing shm_mq.c's volatile qualifiers

2018-02-11 Thread Thomas Munro
Hi, As far as I can see, all the volatile qualifiers in shm_mq.c have been redundant since ec9037df263. Here's a patch to remove them (like several similar patches -- see commit message). Does this make sense? Is there something special about that pointer to volatile pointer to PGPROC? If so I