Re: Rename 'lpp' to 'lp' in heapam.c

2023-05-03 Thread Robert Haas
On Tue, May 2, 2023 at 10:18 PM David Rowley wrote: > I don't really agree that one is any more correct than the other. I > also don't think we should be making changes like this as doing this > may give some false impression that we have some standard to follow > here that a local variable of a g

Re: Rename 'lpp' to 'lp' in heapam.c

2023-05-02 Thread David Rowley
On Wed, 3 May 2023 at 12:16, Yaphters W wrote: > I just found the naming of the ItemId variables is not consistent in > heapam.c. There are 13 'lpp's and 112 'lp's. Technically 'lpp' is correct as > ItemId is a line pointer's pointer and there used to be code like "++lpp" for > line pointer arr

Rename 'lpp' to 'lp' in heapam.c

2023-05-02 Thread Yaphters W
Hi, I just found the naming of the ItemId variables is not consistent in heapam.c. There are 13 'lpp's and 112 'lp's. Technically 'lpp' is correct as ItemId is a line pointer's pointer and there used to be code like "++lpp" for line pointer array iteration. Now that all the "++lpp" code has been r