Re: [HACKERS] Repetitive code in RI triggers

2017-11-18 Thread Tom Lane
Ildar Musin writes: > [ ri_triggers_v2.patch ] Pushed with two minor improvements. I noticed that ri_setdefault could just go directly to ri_restrict rather than call the two separate triggers that would end up there anyway; that lets its argument be "TriggerData

Re: Repetitive code in RI triggers

2017-11-17 Thread Ildus Kurbangaliev
On Fri, 17 Nov 2017 15:05:31 + Ildus Kurbangaliev wrote: > The following review has been posted through the commitfest > application: make installcheck-world: tested, failed > Implements feature: tested, failed > Spec compliant: tested, failed >

Re: Repetitive code in RI triggers

2017-11-17 Thread Ildus Kurbangaliev
The following review has been posted through the commitfest application: make installcheck-world: tested, failed Implements feature: tested, failed Spec compliant: tested, failed Documentation:tested, failed The patch looks good. It just removes repetitive code and I