Re: Rethink the wait event names for postgres_fdw, dblink and etc

2023-10-05 Thread Masahiro Ikeda
On 2023-10-05 10:28, Michael Paquier wrote: On Wed, Oct 04, 2023 at 05:19:40PM +0900, Michael Paquier wrote: I am lacking a bit of time now, but I have applied the bits for test_shm_mq and worker_spi. Note that I have not added tests for test_shm_mq as it may be possible that the two events (fo

Re: Rethink the wait event names for postgres_fdw, dblink and etc

2023-10-04 Thread Michael Paquier
On Wed, Oct 04, 2023 at 05:19:40PM +0900, Michael Paquier wrote: > I am lacking a bit of time now, but I have applied the bits for > test_shm_mq and worker_spi. Note that I have not added tests for > test_shm_mq as it may be possible that the two events (for the > bgworker startup and for a messag

Re: Rethink the wait event names for postgres_fdw, dblink and etc

2023-10-04 Thread Michael Paquier
On Mon, Aug 21, 2023 at 11:04:23AM +0900, Masahiro Ikeda wrote: > I updated the patch to v2. > * Update a comment instead writing documentation about > the wait events for pg_prewarm. Right. It does not seem worth the addition currently, so I am discarded this part. It's just not worth the ext

Re: Rethink the wait event names for postgres_fdw, dblink and etc

2023-08-20 Thread Masahiro Ikeda
Hi, Thanks for your comments. I updated the patch to v2. * Update a comment instead writing documentation about the wait events for pg_prewarm. * Make the name of wait events which are different code path different. Add DblinkGetConnect and PgPrewarmDumpShutdown. * Make variable names shorte

Re: Rethink the wait event names for postgres_fdw, dblink and etc

2023-08-17 Thread Michael Paquier
On Fri, Aug 18, 2023 at 12:27:02PM +0900, Masahiro Ikeda wrote: > I expect that no one will object to changing the names to appropriate > ones. But, we need to discuss that naming convention, the names themselves, > document descriptions and so on. > > I made the v1 patch > * CamelCase naming conv

Rethink the wait event names for postgres_fdw, dblink and etc

2023-08-17 Thread Masahiro Ikeda
Hi, Recently, the API to define custom wait events for extension is supported. * Change custom wait events to use dynamic shared hash tables(af720b4c5) So, I'd like to rethink the wait event names for modules which use "WAIT_EVENT_EXTENSION" wait events. * postgres_fdw * dblink * pg_prewarm *