Re: Return pg_control from pg_backup_stop().

2025-08-06 Thread David Steele
andby->data_dir, '-l', + $node_standby->logfile, 'start' + ]); +ok(!$res, 'invalid recovery startup fails'); + +my $logfile = slurp_file($node_standby->logfile()); +ok($logfile =~ qr/could not find backup_label required for recovery/, + 

Re: Return pg_control from pg_backup_stop().

2025-01-24 Thread David Steele
data on 64-bit architectures. Rebased and improved a comment and an error. Regards, -DavidFrom b229466927f4c17c2c058dbaca92b8ec0429bd80 Mon Sep 17 00:00:00 2001 From: David Steele Date: Fri, 24 Jan 2025 18:38:09 + Subject: Return pg_control from pg_backup_stop(). Harden recovery by returning a cop

Re: Return pg_control from pg_backup_stop().

2024-11-20 Thread David Steele
ds, -David From 659a1d9b6b1528e139741dc69146848ca15a07b9 Mon Sep 17 00:00:00 2001 From: David Steele Date: Wed, 20 Nov 2024 22:33:36 + Subject: Return pg_control from pg_backup_stop(). Harden recovery by returning a copy of pg_control from pg_backup_stop() that has a flag set to prevent recovery if t

Re: Return pg_control from pg_backup_stop().

2024-10-03 Thread David Steele
/backup_label"; + +my $res = run_log( + [ + 'pg_ctl', '-D', $node_standby->data_dir, '-l', + $node_standby->logfile, 'start' + ]); +ok(!$res, 'invalid recovery startup fails'); + +my $logfile = slurp_file($no

Re: Return pg_control from pg_backup_stop().

2024-10-02 Thread Michael Paquier
On Wed, Oct 02, 2024 at 09:03:27AM +, David Steele wrote: > On 10/2/24 10:11, Michael Paquier wrote: >> Hmm, okay. There is also a slight impact for BASE_BACKUP, requiring >> basebackup_progress_wait_wal_archive() and do_pg_backup_stop() to be >> called earlier when sending the main data direc

Re: Return pg_control from pg_backup_stop().

2024-10-02 Thread David Steele
Bjig%2BQdBETj_ab%2B%2BVWSoJjbwT3sLNCnk0wFsY_6tRqoA%40mail.gmail.comFrom f9ebd108a9c5dc55fa485dc8c60eb11d2c16715c Mon Sep 17 00:00:00 2001 From: David Steele Date: Wed, 2 Oct 2024 08:59:12 +0000 Subject: Return pg_control from pg_backup_stop(). Harden recovery by returning a copy of pg_control fr

Re: Return pg_control from pg_backup_stop().

2024-10-02 Thread Michael Paquier
On Fri, May 17, 2024 at 12:46:49PM +1000, David Steele wrote: > This is greatly simplified implementation of the patch proposed in [1] and > hopefully it addresses the concerns expressed there. Since the > implementation is quite different it seemed like a new thread was > appropriate, especially s

Return pg_control from pg_backup_stop().

2024-05-16 Thread David Steele
I'll register this in the July CF. Regards, -David [1] https://www.postgresql.org/message-id/2daf8adc-8db7-4204-a7f2-a7e94e2bf...@pgmasters.netFrom 531872dcdb09f5d2f89af44a3c04c9d2d6da89be Mon Sep 17 00:00:00 2001 From: David Steele Date: Fri, 17 May 2024 02:42:35 + Subject: Return pg_co