Re: Server won't start with fallback setting by initdb.

2018-03-08 Thread Tom Lane
Robert Haas writes: > On Wed, Mar 7, 2018 at 6:43 PM, Michael Paquier wrote: >> On Wed, Mar 07, 2018 at 06:39:32PM -0500, Tom Lane wrote: >>> OK, seems like I'm on the short end of that vote. I propose to push the >>> GUC-crosschecking patch I posted yesterday, but not the default-value >>> chan

Re: Server won't start with fallback setting by initdb.

2018-03-07 Thread Robert Haas
On Wed, Mar 7, 2018 at 6:43 PM, Michael Paquier wrote: > On Wed, Mar 07, 2018 at 06:39:32PM -0500, Tom Lane wrote: >> OK, seems like I'm on the short end of that vote. I propose to push the >> GUC-crosschecking patch I posted yesterday, but not the default-value >> change, and instead push Kyotar

Re: Server won't start with fallback setting by initdb.

2018-03-07 Thread Michael Paquier
On Wed, Mar 07, 2018 at 06:39:32PM -0500, Tom Lane wrote: > OK, seems like I'm on the short end of that vote. I propose to push the > GUC-crosschecking patch I posted yesterday, but not the default-value > change, and instead push Kyotaro-san's initdb change. Should we back-patch > these things t

Re: Server won't start with fallback setting by initdb.

2018-03-07 Thread Tom Lane
Robert Haas writes: > On Tue, Mar 6, 2018 at 10:51 PM, Stephen Frost wrote: >> Changing the defaults to go back down strikes me as an entirely wrong >> approach after we've had a release with the higher defaults without >> seriously compelling arguments against, and I don't agree that we've had >

Re: Server won't start with fallback setting by initdb.

2018-03-07 Thread Robert Haas
On Tue, Mar 6, 2018 at 10:51 PM, Stephen Frost wrote: > Changing the defaults to go back down strikes me as an entirely wrong > approach after we've had a release with the higher defaults without > seriously compelling arguments against, and I don't agree that we've had > such a case made here. I

Re: Server won't start with fallback setting by initdb.

2018-03-06 Thread Stephen Frost
Greetings Tom Peter, all, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Peter Eisentraut writes: > > On 3/4/18 15:31, Tom Lane wrote: > >> Then, seeing that the factory defaults are ReservedBackends = 3 and > >> max_wal_senders = 10, something's got to give; there's no way that > >> max_connections =

Re: Server won't start with fallback setting by initdb.

2018-03-06 Thread Tom Lane
Peter Eisentraut writes: > On 3/4/18 15:31, Tom Lane wrote: >> Then, seeing that the factory defaults are ReservedBackends = 3 and >> max_wal_senders = 10, something's got to give; there's no way that >> max_connections = 10 can work with those. But what I would argue is that >> of those three ch

Re: Server won't start with fallback setting by initdb.

2018-03-06 Thread Tom Lane
I wrote: > Therefore, the condition that actually ought to be getting enforced here > is either "ReservedBackends + max_wal_senders < MaxConnections", or > "ReservedBackends + max_wal_senders <= MaxConnections", depending on > whether you think it's appropriate to require at least one not-reserved-

Re: Server won't start with fallback setting by initdb.

2018-03-06 Thread Peter Eisentraut
On 3/4/18 15:31, Tom Lane wrote: > Then, seeing that the factory defaults are ReservedBackends = 3 and > max_wal_senders = 10, something's got to give; there's no way that > max_connections = 10 can work with those. But what I would argue is that > of those three choices, the least defensible one

Re: Server won't start with fallback setting by initdb.

2018-03-04 Thread Tom Lane
Michael Paquier writes: > On Sun, Mar 04, 2018 at 03:31:31PM -0500, Tom Lane wrote: >> ... But what I would argue is that >> of those three choices, the least defensible one is max_wal_senders = 10. >> Where did that come from? What fraction of real-world installations will >> need that? We don'

Re: Server won't start with fallback setting by initdb.

2018-03-04 Thread Michael Paquier
On Sun, Mar 04, 2018 at 03:31:31PM -0500, Tom Lane wrote: > Then, seeing that the factory defaults are ReservedBackends = 3 and > max_wal_senders = 10, something's got to give; there's no way that > max_connections = 10 can work with those. But what I would argue is that > of those three choices,

Re: Server won't start with fallback setting by initdb.

2018-03-04 Thread Tom Lane
Robert Haas writes: > On Fri, Feb 9, 2018 at 3:08 AM, Kyotaro HORIGUCHI > wrote: >> I think that we can safely increase the fallback value to 20 with >> which regtests are known not to fail. > I propose an alternative fix: let's instead change the code like this: > if (max_wal_senders >

Re: Server won't start with fallback setting by initdb.

2018-02-28 Thread Robert Haas
On Fri, Feb 9, 2018 at 3:08 AM, Kyotaro HORIGUCHI wrote: > I'm not sure such a case happens in the real world nowadays, > initdb uses the fallback value of max_connections=10. But it is > out of favor of server since it is not larger than > max_wal_senders(10). > >> postgres: max_wal_senders must

Re: Server won't start with fallback setting by initdb.

2018-02-27 Thread Michael Paquier
On Wed, Feb 14, 2018 at 10:08:06AM +0900, Kyotaro HORIGUCHI wrote: > Definitely. The another rationale for the value is that regtest > fails with the numbers less than 20. So it's not 11 but > 20. Currently regtest should succeed with that number of > connections as written in parallel_schedule and

Re: Server won't start with fallback setting by initdb.

2018-02-13 Thread Kyotaro HORIGUCHI
Hello, At Mon, 12 Feb 2018 22:28:15 +0900, Michael Paquier wrote in <20180212132815.gb18...@paquier.xyz> > On Fri, Feb 09, 2018 at 05:08:23PM +0900, Kyotaro HORIGUCHI wrote: > > > postgres: max_wal_senders must be less than max_connections > > > > I think that we can safely increase the fallbac

Re: Server won't start with fallback setting by initdb.

2018-02-12 Thread Michael Paquier
On Fri, Feb 09, 2018 at 05:08:23PM +0900, Kyotaro HORIGUCHI wrote: > > postgres: max_wal_senders must be less than max_connections > > I think that we can safely increase the fallback value to 20 with > which regtests are known not to fail. I believe that is > preferable than explicitly reducing m

Server won't start with fallback setting by initdb.

2018-02-09 Thread Kyotaro HORIGUCHI
Hello. I'm not sure such a case happens in the real world nowadays, initdb uses the fallback value of max_connections=10. But it is out of favor of server since it is not larger than max_wal_senders(10). > postgres: max_wal_senders must be less than max_connections I think that we can safely inc