Re: Should rename "startup process" to something else?

2021-11-24 Thread Robert Haas
On Wed, Nov 24, 2021 at 1:54 PM Alvaro Herrera wrote: > I don't object to an underscore, but it looks a bit uglier to me. > AFAIK the main problem with uuid-ossp was that it is used as an identifier, so > it required quoting, which won't be the case with this process name. I agree, and for that r

Re: Should rename "startup process" to something else?

2021-11-24 Thread Tom Lane
Alvaro Herrera writes: > On 2021-Nov-23, Tom Lane wrote: >> Bad memories of uuid-ossp float up ... can we use underscore? > I don't object to an underscore, but it looks a bit uglier to me. > AFAIK the main problem with uuid-ossp was that it is used as an identifier, so > it required quoting, whi

Re: Should rename "startup process" to something else?

2021-11-24 Thread Alvaro Herrera
On 2021-Nov-23, Tom Lane wrote: > Alvaro Herrera writes: > > On 2021-Nov-20, Andrew Dunstan wrote: > >> Maybe something along those lines but using a dash/hyphen would work: > >> e.g. wal-replayer > > > Yeah, the idea of a dash occurred to me too. > > Bad memories of uuid-ossp float up ... can

Re: Should rename "startup process" to something else?

2021-11-23 Thread Tom Lane
Alvaro Herrera writes: > On 2021-Nov-20, Andrew Dunstan wrote: >> Maybe something along those lines but using a dash/hyphen would work: >> e.g. wal-replayer > Yeah, the idea of a dash occurred to me too. Bad memories of uuid-ossp float up ... can we use underscore? regar

Re: Should rename "startup process" to something else?

2021-11-23 Thread Alvaro Herrera
On 2021-Nov-20, Andrew Dunstan wrote: > Maybe something along those lines but using a dash/hyphen would work: > e.g. wal-replayer Yeah, the idea of a dash occurred to me too. -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/ "La grandeza es una experiencia transit

Re: Should rename "startup process" to something else?

2021-11-20 Thread Andrew Dunstan
On 11/18/21 15:22, Tom Lane wrote: > Alvaro Herrera writes: >> If we change the name, and I support the idea that we do, I think a >> good name would be "wal replay". I think "recovery" is not great >> precisely because in a standby there is likely no crash that we're >> recovering from. > Fair

Re: Should rename "startup process" to something else?

2021-11-19 Thread Michael Paquier
On Fri, Nov 19, 2021 at 11:45:40PM +, Bossart, Nathan wrote: > +1 to something like "wal replay" or "wal apply." My view is that > terms like "startup" and "recovery" indicate the goal of the process > while "replay" and "apply" just explain what it does. This would be > in line with the othe

Re: Should rename "startup process" to something else?

2021-11-19 Thread Bossart, Nathan
On 11/18/21, 12:24 PM, "Tom Lane" wrote: > Alvaro Herrera writes: >> If we change the name, and I support the idea that we do, I think a >> good name would be "wal replay". I think "recovery" is not great >> precisely because in a standby there is likely no crash that we're >> recovering from. >

Re: Should rename "startup process" to something else?

2021-11-18 Thread Tom Lane
Alvaro Herrera writes: > If we change the name, and I support the idea that we do, I think a > good name would be "wal replay". I think "recovery" is not great > precisely because in a standby there is likely no crash that we're > recovering from. Fair point. > The word "replay" is at odds with

Re: Should rename "startup process" to something else?

2021-11-18 Thread Alvaro Herrera
On 2021-Nov-18, Tom Lane wrote: > Justin Pryzby writes: > > On Thu, Nov 18, 2021 at 12:24:14PM -0500, Tom Lane wrote: > >> Personally I think making a glossary entry that explains what the > >> process does would be a better plan than renaming it. > > > Since d3014fff4: > > https://www.postgresq

Re: Should rename "startup process" to something else?

2021-11-18 Thread Robert Haas
On Thu, Nov 18, 2021 at 12:24 PM Tom Lane wrote: > Being hackers ourselves, I'm not sure we're qualified to opine on > that. I cannot say that I've noticed any questions about it on > the mailing lists, though. What I've noticed when supporting EDB customer is that if, say, there's a problem wit

Re: Should rename "startup process" to something else?

2021-11-18 Thread Tom Lane
Justin Pryzby writes: > On Thu, Nov 18, 2021 at 12:24:14PM -0500, Tom Lane wrote: >> Personally I think making a glossary entry that explains what the >> process does would be a better plan than renaming it. > Since d3014fff4: > https://www.postgresql.org/docs/devel/glossary.html#GLOSSARY-STARTUP

Re: Should rename "startup process" to something else?

2021-11-18 Thread Justin Pryzby
On Thu, Nov 18, 2021 at 12:24:14PM -0500, Tom Lane wrote: > Robert Haas writes: > > On Thu, Nov 18, 2021 at 11:05 AM Tom Lane wrote: > >> Yeah, given current usage it would be better to call it the "recovery > >> process". However, I'm feeling dubious that it's worth the cost to > >> change. Th

Re: Should rename "startup process" to something else?

2021-11-18 Thread Thomas Munro
On Tue, Nov 16, 2021 at 3:33 AM Rushabh Lathia wrote: > I think a better name for the process may be “recovery” +1

Re: Should rename "startup process" to something else?

2021-11-18 Thread Tom Lane
Robert Haas writes: > On Thu, Nov 18, 2021 at 11:05 AM Tom Lane wrote: >> Yeah, given current usage it would be better to call it the "recovery >> process". However, I'm feeling dubious that it's worth the cost to >> change. The "startup" name is embedded in a lot of places, I think, >> and peo

Re: Should rename "startup process" to something else?

2021-11-18 Thread Robert Haas
On Thu, Nov 18, 2021 at 11:05 AM Tom Lane wrote: > Yeah, given current usage it would be better to call it the "recovery > process". However, I'm feeling dubious that it's worth the cost to > change. The "startup" name is embedded in a lot of places, I think, > and people are used to it. I fear

Re: Should rename "startup process" to something else?

2021-11-18 Thread Tom Lane
Robert Haas writes: > That's true, but those tasks are very brief. Nobody's going to get too > confused by a "recovery" process that shows up for a few milliseconds > when there's no recovery to be done. Having a "startup" process that > sticks around forever on a standy, though, actually is confu

Re: Should rename "startup process" to something else?

2021-11-18 Thread Robert Haas
On Thu, Nov 18, 2021 at 5:34 AM Bharath Rupireddy wrote: > The startup process main function looks to be to do some > initialization required for recovery and do the recovery, exit if it > is a crash recovery or stay there if it is a standby recovery. Apart > from these I'm not sure it does any no

Re: Should rename "startup process" to something else?

2021-11-18 Thread Amul Sul
On Thu, Nov 18, 2021 at 6:06 PM Andrey Borodin wrote: > > > > > 15 нояб. 2021 г., в 19:32, Rushabh Lathia > > написал(а): > > > > Open for suggestions and thoughts. > > > How about walapplier ? > Similar to walsender, walreciver.. > Or maybe walreplayer ? Regards, Amul

Re: Should rename "startup process" to something else?

2021-11-18 Thread Andrey Borodin
> 15 нояб. 2021 г., в 19:32, Rushabh Lathia > написал(а): > > Open for suggestions and thoughts. How about walapplier ? Similar to walsender, walreciver.. Best regards, Andrey Borodin.

Re: Should rename "startup process" to something else?

2021-11-18 Thread Bharath Rupireddy
On Mon, Nov 15, 2021 at 8:03 PM Rushabh Lathia wrote: > Robert and I wondered whether we would like to rename the startup > > process. The reason for doing this is that the current name doesn't > > make any sense, as in the stand-by mode replay loop as the main > > loop, the startup process stays

Should rename "startup process" to something else?

2021-11-15 Thread Rushabh Lathia
Hi, Robert and I wondered whether we would like to rename the startup process. The reason for doing this is that the current name doesn't make any sense, as in the stand-by mode replay loop as the main loop, the startup process stays around. I think a better name for the process may be “reco