Should we make Bitmapsets a kind of Node?

2021-01-29 Thread Tom Lane
I got annoyed (not for the first time) by the fact that the partitioned_rels field of AppendPath and MergeAppendPath is a list of Relids, i.e., Bitmapsets. This is problematic because a Bitmapset is not a type of Node, and thus a List of them is really an invalid data structure. The main practica

Re: Should we make Bitmapsets a kind of Node?

2021-01-29 Thread Peter Geoghegan
On Fri, Jan 29, 2021 at 12:12 PM Tom Lane wrote: > I got annoyed (not for the first time) by the fact that the > partitioned_rels field of AppendPath and MergeAppendPath is a list of > Relids, i.e., Bitmapsets. This is problematic because a Bitmapset is > not a type of Node, and thus a List of th

Re: Should we make Bitmapsets a kind of Node?

2021-01-29 Thread Tom Lane
Peter Geoghegan writes: > On Fri, Jan 29, 2021 at 12:12 PM Tom Lane wrote: >> I got annoyed (not for the first time) by the fact that the >> partitioned_rels field of AppendPath and MergeAppendPath is a list of >> Relids, i.e., Bitmapsets. This is problematic because a Bitmapset is >> not a type

Re: Should we make Bitmapsets a kind of Node?

2021-01-29 Thread Peter Geoghegan
On Fri, Jan 29, 2021 at 4:01 PM Tom Lane wrote: > > It's probably much riskier to use 32-bit x86 today than > > it is to use (say) POWER8, or some other contemporary minority > > platform. > > We do still have x86 in the buildfarm, as well as some other > 32-bit platforms, so I don't agree that it

Re: Should we make Bitmapsets a kind of Node?

2021-01-29 Thread Tom Lane
Peter Geoghegan writes: > On Fri, Jan 29, 2021 at 4:01 PM Tom Lane wrote: >> We do still have x86 in the buildfarm, as well as some other >> 32-bit platforms, so I don't agree that it's that much less >> tested than non-mainstream 64-bit platforms. > I don't know anybody that still runs Postgres

Re: Should we make Bitmapsets a kind of Node?

2021-01-29 Thread Michael Paquier
On Fri, Jan 29, 2021 at 08:53:49PM -0500, Tom Lane wrote: > Peter Geoghegan writes: >> I don't know anybody that still runs Postgres >> (or anything like it) on a 32-bit platform. I think that Michael >> Paquier owns a Raspberry Pi zero, but that hardly counts. hamster died a couple of years ago,

Re: Should we make Bitmapsets a kind of Node?

2021-01-29 Thread Peter Geoghegan
On Fri, Jan 29, 2021 at 5:53 PM Tom Lane wrote: > Hmph ... three of my five buildfarm animals are 32-bit, plus I > have got 32-bit OSes for my Raspberry Pi ;-). Admittedly, none > of those represent hardware someone would put a serious database > on today. But in terms of testing diversity, I th

Re: Should we make Bitmapsets a kind of Node?

2021-01-29 Thread Peter Geoghegan
On Fri, Jan 29, 2021 at 6:33 PM Michael Paquier wrote: > Those 32-bit modules are still being sold actively by the RPI > foundation, and used as cheap machines for education purposes, so I > think that it is still useful for Postgres to have active buildfarm > members for 32-bit architectures. Bu

Re: Should we make Bitmapsets a kind of Node?

2021-01-29 Thread Tom Lane
Peter Geoghegan writes: > Broad trends have made it easier to write portable C code, but that > doesn't apply to 32-bit machines, I imagine. Including even the > extremely low power 32-bit chips that are not yet fully obsolete, like > the Raspberry Pi Zero's chip. Meh. To my mind, the most inter

Re: Should we make Bitmapsets a kind of Node?

2021-01-29 Thread Peter Geoghegan
On Fri, Jan 29, 2021 at 6:44 PM Tom Lane wrote: > Pointer width is interesting, but really it's a solved problem > compared to these. What about USE_FLOAT8_BYVAL? -- Peter Geoghegan

Re: Should we make Bitmapsets a kind of Node?

2021-01-30 Thread Tom Lane
Peter Geoghegan writes: > On Fri, Jan 29, 2021 at 6:44 PM Tom Lane wrote: >> Pointer width is interesting, but really it's a solved problem >> compared to these. > What about USE_FLOAT8_BYVAL? That's an annoyance, sure, but I don't recall many recent bugs related to violations of that coding ru

Re: Should we make Bitmapsets a kind of Node?

2021-02-01 Thread Tom Lane
Now that commit f003a7522 did away with the partitioned_rels fields, my original motivation for doing $SUBJECT is gone. It might still be worth doing, but I'm not planning to tackle it right now. regards, tom lane

Re: Should we make Bitmapsets a kind of Node?

2021-02-01 Thread David Rowley
On Tue, 2 Feb 2021 at 09:23, Tom Lane wrote: > > Now that commit f003a7522 did away with the partitioned_rels fields, > my original motivation for doing $SUBJECT is gone. It might still be > worth doing, but I'm not planning to tackle it right now. I'm not sure if the misuse of Lists to store no

Re: Should we make Bitmapsets a kind of Node?

2021-02-01 Thread Tom Lane
David Rowley writes: > On Tue, 2 Feb 2021 at 09:23, Tom Lane wrote: >> Now that commit f003a7522 did away with the partitioned_rels fields, >> my original motivation for doing $SUBJECT is gone. It might still be >> worth doing, but I'm not planning to tackle it right now. > I'm not sure if the