RE: Showing applied extended statistics in explain Part 2

2024-07-19 Thread Masahiro.Ikeda
> On 7/18/24 12:37, masahiro.ik...@nttdata.com wrote: > >> Let me share my opinion on those questions ... > > ...> > >> For ndistinct, I think we don't show this because it doesn't go > >> through clauselist_selectivity, which is the only thing I modified in the > >> PoC. > >> But I guess we might

Re: Showing applied extended statistics in explain Part 2

2024-07-18 Thread Tomas Vondra
On 7/18/24 12:37, masahiro.ik...@nttdata.com wrote: >> Let me share my opinion on those questions ... > ...> >> For ndistinct, I think we don't show this because it doesn't go through >> clauselist_selectivity, which is the only thing I modified in the PoC. >> But I guess we might improve estimate_

RE: Showing applied extended statistics in explain Part 2

2024-07-18 Thread Masahiro.Ikeda
> Let me share my opinion on those questions ... Thanks! I could understand the patch well thanks to your comments. > On 7/12/24 12:09, masahiro.ik...@nttdata.com wrote: > > Is it better to make the order of output consistent? For example, even > > though there are three clauses shown in the be

Re: Showing applied extended statistics in explain Part 2

2024-07-15 Thread Tomas Vondra
Hi, Let me share my opinion on those questions ... On 7/12/24 12:09, masahiro.ik...@nttdata.com wrote: > Hi, > > Thanks for working the feature. As a user, I find it useful, and I'd like to > use > it in v18! Although I've just started start looking into it, I have a few > questions. > > >

Re: Showing applied extended statistics in explain Part 2

2024-07-15 Thread Tomas Vondra
On 6/28/24 13:16, Tatsuro Yamada wrote: > Hi Tomas and All, > > Attached file is a new patch including: > 6) Add stats option to explain command > 7) The patch really needs some docs (partly) > > >4) Add new node (resolve errors in cfbot and prepared statement) > > I tried adding a new

Re: Showing applied extended statistics in explain Part 2

2024-07-15 Thread Tomas Vondra
On 6/26/24 11:06, Tatsuro Yamada wrote: > Hi Tomas! > > Thanks for the comments! > > 1) The patch is not added to the CF app, which I think is a mistake. Can >> you please add it to the 2024-07 commitfest? Otherwise people may not be >> aware of it, won't do reviews etc. It'll require posting

RE: Showing applied extended statistics in explain Part 2

2024-07-12 Thread Masahiro.Ikeda
Hi, Thanks for working the feature. As a user, I find it useful, and I'd like to use it in v18! Although I've just started start looking into it, I have a few questions. (1) Is it better to make the order of output consistent? For example, even though there are three clauses shown in the below

Re: Showing applied extended statistics in explain Part 2

2024-06-28 Thread Tatsuro Yamada
Hi Tomas and All, Attached file is a new patch including: 6) Add stats option to explain command 7) The patch really needs some docs (partly) >4) Add new node (resolve errors in cfbot and prepared statement) I tried adding a new node in pathnode.h, but it doesn't work well. So, it needs

Re: Showing applied extended statistics in explain Part 2

2024-06-27 Thread Tatsuro Yamada
Hi Tomas, The attached patch does not correspond to the above comment. > But it does solve some of the issues mentioned in previous threads. > Oops, I made a mistake sending a patch on my previous email. Attached patch is the right patch. Regards, Tatsuro Yamada 0001-Add-Showing-applied-extend

Re: Showing applied extended statistics in explain Part 2

2024-06-26 Thread Tatsuro Yamada
Hi Tomas! Thanks for the comments! 1) The patch is not added to the CF app, which I think is a mistake. Can > you please add it to the 2024-07 commitfest? Otherwise people may not be > aware of it, won't do reviews etc. It'll require posting a rebased > patch, but should not be a big deal. > I a

Re: Showing applied extended statistics in explain Part 2

2024-06-12 Thread Tomas Vondra
Hello Yamada-san, I finally got to look at this patch again - apologies for taking so long, I'm well aware it's rather frustrating to wait for feedback. I'll try to pay more attention to this patch, and don't hesitate to ping me off-list if immediate input is needed. I looked at the patch from Ma

Re: Showing applied extended statistics in explain Part 2

2024-03-01 Thread Tomas Vondra
On 3/1/24 01:19, Tatsuro Yamada wrote: > Hi, > > This original patch made by Tomas improves the usability of extended > statistics, > so I rebased it on 362de947, and I'd like to re-start developing it. > > The previous thread [1] suggested something to solve. I'll try to solve it as > best I

Showing applied extended statistics in explain Part 2

2024-02-29 Thread Tatsuro Yamada
Hi, This original patch made by Tomas improves the usability of extended statistics, so I rebased it on 362de947, and I'd like to re-start developing it. The previous thread [1] suggested something to solve. I'll try to solve it as best I can, but I think this feature is worth it with some li